From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 946B81F4B4 for ; Mon, 4 Jan 2021 04:50:20 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2217B120BD4; Mon, 4 Jan 2021 13:49:25 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6694F120BD3 for ; Mon, 4 Jan 2021 13:49:22 +0900 (JST) Received: by filterdrecv-p3las1-685fdc5bbc-689nv with SMTP id filterdrecv-p3las1-685fdc5bbc-689nv-19-5FF29E80-12 2021-01-04 04:50:08.289623411 +0000 UTC m=+2094468.437744006 Received: from herokuapp.com (unknown) by geopod-ismtpd-3-9 (SG) with ESMTP id MLcmLhXrS_eUxbfYm_ngDg for ; Mon, 04 Jan 2021 04:50:08.032 +0000 (UTC) Date: Mon, 04 Jan 2021 04:50:08 +0000 (UTC) From: takashikkbn@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77809 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17490 X-Redmine-Issue-Author: k0kubun X-Redmine-Sender: k0kubun X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?9bN4wU0cxWeLAEOz6NELGbwCNAokUg6cnjH8nvx=2FqgZM+PUDZm5uFsOJ0EEA7a?= =?us-ascii?Q?r2rKOEWYKrqkBu8WKpSKaYhsPnTSmS9Q0bdlmqw?= =?us-ascii?Q?JdYzrz3tIBRUvmY1nm9fOcDHVP=2F1onJuSUFLdqJ?= =?us-ascii?Q?Pu=2FwGBK9GUlO8PeNmHzP7E2a9C3t4lYp5pfgyId?= =?us-ascii?Q?Y3BEXt61ftrU6ovhTHq7Ny7A+FOF6=2FLp1+4eplQ?= =?us-ascii?Q?3dWHha2LAsqCKO4jw=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101902 Subject: [ruby-core:101902] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17490 has been updated by k0kubun (Takashi Kokubun). This thread is already too long for off topics, so let me focus on the name of `RubyVM::MJIT` in this ticket and leave the release notes discussion to elsewhere. > I don't see why an internal/experimental module (RubyVM::MJIT) need to have name understandable by people knowing nothing about MJIT. > I'd say users of RubyVM::MJIT should at least know the name of the JIT before using those APIs. If the feature will continue to be MJIT-specific, your point would make sense. But as I'm trying to make `--jit` and `RubyVM::MJIT` consistent in terms of their name, I think their feature should also be consistent; `RubyVM::MJIT.pause/resume` should control not only MJIT but also other JITs if `--jit` is going to enable all future tiers of JIT. I think the number of JIT-relaed APIs should be as few as possible, and this change will contribute to limiting per-JIT features, i.e. I don't want `RubyVM::YetAnotherJIT` in the future. By the way, let me point out again that this feature is mainly for MJIT's development / testing and not for people who don't contribute to developing MJIT. Please don't take my development time away for discussing this if you only care about TruffleRuby's compatibility with modules under RubyVM, because clearly there's no need to do so. ---------------------------------------- Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT https://bugs.ruby-lang.org/issues/17490#change-89742 * Author: k0kubun (Takashi Kokubun) * Status: Open * Priority: Normal ---------------------------------------- ## Background In my understanding, MJIT is a codename like YARV which many people outside Ruby community are not familiar with, so I've used JIT in NEWS or release notes to avoid explaining the "M" part whenever we release a new version. However, because we have the name "MJIT" in one of our constants, we've had some naming inconsistency. For instance, --jit is not --mjit and it's not consistent. ## Proposal Have the same constant as `RubyVM::JIT`, deprecate `RubyVM::MJIT` from Ruby 3.1, and remove the old one in Ruby 3.2. ## Impact This impacts only [Feature #14830] `RubyVM::MJIT.pause` / `RubyVM::MJIT.resume`, which is basically for k0kubun's own testing. -- https://bugs.ruby-lang.org/