ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:101812] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT
Date: Wed, 30 Dec 2020 15:05:00 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-89639.20201230150459.10073@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17490.20201230054510.10073@ruby-lang.org

Issue #17490 has been updated by Eregon (Benoit Daloze).


If we'd consider RubyVM is CRuby-specific, then it seems fine.
However, that's rather unclear, and then the question is what should other Ruby implementations should do `RubyVM::MJIT` and its methods?
(other Ruby implementations might be forced to define `RubyVM` for compatibility at some point, it wouldn't surprise me)

I think Ruby users should anyway not need to use RubyVM::MJIT methods, so I prefer the more precise `MJIT` name.
`RubyVM` is already awfully confusing. `RubyVM::JIT` sounds like a general/portable API (from the name) when it is in fact CRuby-specific.

IMHO, a benchmark harness should not need to use a JIT-specific API, so I think `pause`/`resume` are only useful for debugging.

`RubyVM::MJIT.enabled?` could become a portable API, but it would need to move somewhere else.
I'm also unsure if it's needed besides MRI tests, in part because all major Ruby implementations already show if there is a JIT in `RUBY_DESCRIPTION`.

----------------------------------------
Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT
https://bugs.ruby-lang.org/issues/17490#change-89639

* Author: k0kubun (Takashi Kokubun)
* Status: Open
* Priority: Normal
----------------------------------------
## Background
In my understanding, MJIT is a codename like YARV which many people outside Ruby community are not familiar with, so I've used JIT in NEWS or release notes to avoid explaining the "M" part whenever we release a new version. However, because we have the name "MJIT" in one of our constants, we've had some naming inconsistency. For instance, --jit is not --mjit and it's not consistent.

## Proposal
Have the same constant as `RubyVM::JIT`, deprecate `RubyVM::MJIT` from Ruby 3.1, and remove the old one in Ruby 3.2.



-- 
https://bugs.ruby-lang.org/

  reply	other threads:[~2020-12-30 15:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  5:45 [ruby-core:101809] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT takashikkbn
2020-12-30 15:05 ` eregontp [this message]
2020-12-30 22:59 ` [ruby-core:101821] " nobu
2020-12-31  7:47 ` [ruby-core:101832] " takashikkbn
2020-12-31  8:05 ` [ruby-core:101833] " hsbt
2021-01-01 12:20 ` [ruby-core:101851] " eregontp
2021-01-01 12:48 ` [ruby-core:101853] " eregontp
2021-01-02  3:06 ` [ruby-core:101874] " takashikkbn
2021-01-02 12:50 ` [ruby-core:101879] " eregontp
2021-01-02 15:51 ` [ruby-core:101880] " takashikkbn
2021-01-03 13:28 ` [ruby-core:101886] " eregontp
2021-01-04  4:50 ` [ruby-core:101902] " takashikkbn
2021-01-13  6:29 ` [ruby-core:102051] " matz
2022-01-17  6:00 ` [ruby-core:107154] " znz (Kazuhiro NISHIYAMA)
2022-01-17  6:32 ` [ruby-core:107155] " k0kubun (Takashi Kokubun)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-89639.20201230150459.10073@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).