From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id B5FFE1F4B4 for ; Wed, 30 Dec 2020 15:05:17 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4E9DF120A0F; Thu, 31 Dec 2020 00:04:23 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id F135E120A0E for ; Thu, 31 Dec 2020 00:04:20 +0900 (JST) Received: by filterdrecv-p3las1-685fdc5bbc-ph5zt with SMTP id filterdrecv-p3las1-685fdc5bbc-ph5zt-20-5FEC971C-52 2020-12-30 15:05:00.747352422 +0000 UTC m=+1699368.521320891 Received: from herokuapp.com (unknown) by ismtpd0055p1mdw1.sendgrid.net (SG) with ESMTP id tERRqzt7Rl2DBHM3qGjMcA for ; Wed, 30 Dec 2020 15:05:00.585 +0000 (UTC) Date: Wed, 30 Dec 2020 15:05:00 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77714 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17490 X-Redmine-Issue-Author: k0kubun X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr36Xz7rUowbgbd2Onw=2Fk5?= =?us-ascii?Q?Z18TEBBBEdRRvRz9=2FE0KsyfQ+kBDJf5U1X6umzb?= =?us-ascii?Q?r1BQCQf3phoKr0uE6fGW1=2FbEgGF4BnLS334Oe0g?= =?us-ascii?Q?ZvnV5VIhIQyBsx9KAT5FC06ZoGLSt7GfbQZTNDi?= =?us-ascii?Q?VqTfTk=2FYm5m+zugaCnLQAJtfXPtzLfpsBzQWJT4?= =?us-ascii?Q?AmJiqq6ddoyCy=2Fu84=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101812 Subject: [ruby-core:101812] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17490 has been updated by Eregon (Benoit Daloze). If we'd consider RubyVM is CRuby-specific, then it seems fine. However, that's rather unclear, and then the question is what should other Ruby implementations should do `RubyVM::MJIT` and its methods? (other Ruby implementations might be forced to define `RubyVM` for compatibility at some point, it wouldn't surprise me) I think Ruby users should anyway not need to use RubyVM::MJIT methods, so I prefer the more precise `MJIT` name. `RubyVM` is already awfully confusing. `RubyVM::JIT` sounds like a general/portable API (from the name) when it is in fact CRuby-specific. IMHO, a benchmark harness should not need to use a JIT-specific API, so I think `pause`/`resume` are only useful for debugging. `RubyVM::MJIT.enabled?` could become a portable API, but it would need to move somewhere else. I'm also unsure if it's needed besides MRI tests, in part because all major Ruby implementations already show if there is a JIT in `RUBY_DESCRIPTION`. ---------------------------------------- Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT https://bugs.ruby-lang.org/issues/17490#change-89639 * Author: k0kubun (Takashi Kokubun) * Status: Open * Priority: Normal ---------------------------------------- ## Background In my understanding, MJIT is a codename like YARV which many people outside Ruby community are not familiar with, so I've used JIT in NEWS or release notes to avoid explaining the "M" part whenever we release a new version. However, because we have the name "MJIT" in one of our constants, we've had some naming inconsistency. For instance, --jit is not --mjit and it's not consistent. ## Proposal Have the same constant as `RubyVM::JIT`, deprecate `RubyVM::MJIT` from Ruby 3.1, and remove the old one in Ruby 3.2. -- https://bugs.ruby-lang.org/