ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:90055] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
@ 2018-11-25  3:56 ` Greg.mpls
  2018-11-25  4:21 ` [ruby-core:90056] " Greg.mpls
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: Greg.mpls @ 2018-11-25  3:56 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been reported by MSP-Greg (Greg L).

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90056] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
  2018-11-25  3:56 ` [ruby-core:90055] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ? Greg.mpls
@ 2018-11-25  4:21 ` Greg.mpls
  2018-11-25 12:01 ` [ruby-core:90058] " happy
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: Greg.mpls @ 2018-11-25  4:21 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by MSP-Greg (Greg L).

File pr_2028.patch added

Sorry for not mentioning it, but GH PR is just for Appveyor.  Not sure if code should be added to all Travis builds...

PR CI failed for all three builds on Appveyor.  All errors similar to:

```
\usr\bin\bundle --version
C:/usr/bin/bundle.cmd:33:in `load': cannot load such file -- C:/usr/lib/ruby/gems/2.6.0/gems/bundler-2.0.0.pre.1/exe/bundle (LoadError)
	from C:/usr/bin/bundle.cmd:33:in `<main>'

Command exited with code 1
```

Something must be wrong with the bundler install code.

Patch attached.

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75164

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (1.39 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90058] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
  2018-11-25  3:56 ` [ruby-core:90055] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ? Greg.mpls
  2018-11-25  4:21 ` [ruby-core:90056] " Greg.mpls
@ 2018-11-25 12:01 ` happy
  2018-11-25 13:38 ` [ruby-core:90059] " Greg.mpls
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: happy @ 2018-11-25 12:01 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by junaruga (Jun Aruga).


How about creating this check in make task "make test" or "make test-all"?


----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75166

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (1.39 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90059] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2018-11-25 12:01 ` [ruby-core:90058] " happy
@ 2018-11-25 13:38 ` Greg.mpls
  2018-11-25 20:04 ` [ruby-core:90062] " Greg.mpls
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: Greg.mpls @ 2018-11-25 13:38 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by MSP-Greg (Greg L).


@junaruga

1) I believe I have seen discussions on whether `make install` should be included in CI or not.

2) The test suites can be run before `make install`.

3) I'm not a good choice for making changes re Makefile, especially for cross platform use.

Given the above, I thought starting with Ruby's own Windows CI would be a good start.

JFYI, ruby-loco is running every test suite except basic from install (without using make).  The build folder could be deleted beforehand.  There were a few files that needed changing for that...

Thanks, Greg

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75167

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (1.39 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90062] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
                   ` (3 preceding siblings ...)
  2018-11-25 13:38 ` [ruby-core:90059] " Greg.mpls
@ 2018-11-25 20:04 ` Greg.mpls
  2018-11-26  2:08 ` [ruby-core:90064] [Ruby trunk Bug#15339][Assigned] " hsbt
  2018-12-13 11:55 ` [ruby-core:90506] [Ruby trunk Bug#15339][Closed] " hsbt
  6 siblings, 0 replies; 7+ messages in thread
From: Greg.mpls @ 2018-11-25 20:04 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by MSP-Greg (Greg L).

File pr_2028.patch added

Added 3 lines to rbinstall.rb, added bundle_ruby to Bundler's executables.

Both are minor fixups to r65963.  Passes on Appveyor.  Patch file updated.  Nothing changed re Travis...

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75172

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (2.76 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90064] [Ruby trunk Bug#15339][Assigned] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
                   ` (4 preceding siblings ...)
  2018-11-25 20:04 ` [ruby-core:90062] " Greg.mpls
@ 2018-11-26  2:08 ` hsbt
  2018-12-13 11:55 ` [ruby-core:90506] [Ruby trunk Bug#15339][Closed] " hsbt
  6 siblings, 0 replies; 7+ messages in thread
From: hsbt @ 2018-11-26  2:08 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Assigned
Assignee set to hsbt (Hiroshi SHIBATA)

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75175

* Author: MSP-Greg (Greg L)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (2.76 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:90506] [Ruby trunk Bug#15339][Closed] CI - add checks for std-lib CLI ?
       [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
                   ` (5 preceding siblings ...)
  2018-11-26  2:08 ` [ruby-core:90064] [Ruby trunk Bug#15339][Assigned] " hsbt
@ 2018-12-13 11:55 ` hsbt
  6 siblings, 0 replies; 7+ messages in thread
From: hsbt @ 2018-12-13 11:55 UTC (permalink / raw)
  To: ruby-core

Issue #15339 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Assigned to Closed

Hi Greg.

Thanks for your report.
This is fixed ar r66384 by @usa.

I will consider to add cli check to our CI after Ruby 2.6 releasing.

----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75664

* Author: MSP-Greg (Greg L)
* Status: Closed
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).

---Files--------------------------------
pr_2028.patch (2.76 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-12-13 11:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
2018-11-25  3:56 ` [ruby-core:90055] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ? Greg.mpls
2018-11-25  4:21 ` [ruby-core:90056] " Greg.mpls
2018-11-25 12:01 ` [ruby-core:90058] " happy
2018-11-25 13:38 ` [ruby-core:90059] " Greg.mpls
2018-11-25 20:04 ` [ruby-core:90062] " Greg.mpls
2018-11-26  2:08 ` [ruby-core:90064] [Ruby trunk Bug#15339][Assigned] " hsbt
2018-12-13 11:55 ` [ruby-core:90506] [Ruby trunk Bug#15339][Closed] " hsbt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).