From: Greg.mpls@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90059] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ?
Date: Sun, 25 Nov 2018 13:38:24 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-75167.20181125133822.88ad53ff9e13b709@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15339.20181125035623@ruby-lang.org
Issue #15339 has been updated by MSP-Greg (Greg L).
@junaruga
1) I believe I have seen discussions on whether `make install` should be included in CI or not.
2) The test suites can be run before `make install`.
3) I'm not a good choice for making changes re Makefile, especially for cross platform use.
Given the above, I thought starting with Ruby's own Windows CI would be a good start.
JFYI, ruby-loco is running every test suite except basic from install (without using make). The build folder could be deleted beforehand. There were a few files that needed changing for that...
Thanks, Greg
----------------------------------------
Bug #15339: CI - add checks for std-lib CLI ?
https://bugs.ruby-lang.org/issues/15339#change-75167
* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Currently, CI is largely ignorant of the install.
Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.
See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).
---Files--------------------------------
pr_2028.patch (1.39 KB)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2018-11-25 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15339.20181125035623@ruby-lang.org>
2018-11-25 3:56 ` [ruby-core:90055] [Ruby trunk Bug#15339] CI - add checks for std-lib CLI ? Greg.mpls
2018-11-25 4:21 ` [ruby-core:90056] " Greg.mpls
2018-11-25 12:01 ` [ruby-core:90058] " happy
2018-11-25 13:38 ` Greg.mpls [this message]
2018-11-25 20:04 ` [ruby-core:90062] " Greg.mpls
2018-11-26 2:08 ` [ruby-core:90064] [Ruby trunk Bug#15339][Assigned] " hsbt
2018-12-13 11:55 ` [ruby-core:90506] [Ruby trunk Bug#15339][Closed] " hsbt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-75167.20181125133822.88ad53ff9e13b709@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).