* [ruby-core:60837] [ruby-trunk - Feature #9532] [Open] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
@ 2014-02-18 22:11 ` arthurnn
2014-02-18 22:17 ` [ruby-core:60838] [ruby-trunk - Feature #9532] [Assigned] " e
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: arthurnn @ 2014-02-18 22:11 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been reported by Arthur Neves.
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532
* Author: Arthur Neves
* Status: Open
* Priority: Normal
* Assignee:
* Category:
* Target version:
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:60838] [ruby-trunk - Feature #9532] [Assigned] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
2014-02-18 22:11 ` [ruby-core:60837] [ruby-trunk - Feature #9532] [Open] Expose logger monitor arthurnn
@ 2014-02-18 22:17 ` e
2014-02-18 22:35 ` [ruby-core:60839] [ruby-trunk - Feature #9532] " shibata.hiroshi
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: e @ 2014-02-18 22:17 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been updated by Zachary Scott.
Category set to lib
Status changed from Open to Assigned
Assignee set to Narihiro Nakamura
Target version set to current: 2.2.0
Please note: a number of libraries are using this class: https://github.com/search?l=ruby&q=LogDeviceMutex&ref=cmdform&type=Code
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532#change-45252
* Author: Arthur Neves
* Status: Assigned
* Priority: Normal
* Assignee: Narihiro Nakamura
* Category: lib
* Target version: current: 2.2.0
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:60839] [ruby-trunk - Feature #9532] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
2014-02-18 22:11 ` [ruby-core:60837] [ruby-trunk - Feature #9532] [Open] Expose logger monitor arthurnn
2014-02-18 22:17 ` [ruby-core:60838] [ruby-trunk - Feature #9532] [Assigned] " e
@ 2014-02-18 22:35 ` shibata.hiroshi
2014-08-13 2:49 ` [ruby-core:64344] [ruby-trunk - Feature #9532] [Feedback] " shibata.hiroshi
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: shibata.hiroshi @ 2014-02-18 22:35 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been updated by Hiroshi SHIBATA.
Assignee changed from Narihiro Nakamura to Hiroshi Nakamura
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532#change-45254
* Author: Arthur Neves
* Status: Assigned
* Priority: Normal
* Assignee: Hiroshi Nakamura
* Category: lib
* Target version: current: 2.2.0
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:64344] [ruby-trunk - Feature #9532] [Feedback] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
` (2 preceding siblings ...)
2014-02-18 22:35 ` [ruby-core:60839] [ruby-trunk - Feature #9532] " shibata.hiroshi
@ 2014-08-13 2:49 ` shibata.hiroshi
2019-07-23 15:10 ` [ruby-core:93887] [Ruby master Feature#9532] " hsbt
2019-08-17 3:42 ` [ruby-core:94397] " sonots
5 siblings, 0 replies; 6+ messages in thread
From: shibata.hiroshi @ 2014-08-13 2:49 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been updated by Hiroshi SHIBATA.
Status changed from Assigned to Feedback
Your patch broke logger and syslog/logger tests.
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532#change-48324
* Author: Arthur Neves
* Status: Feedback
* Priority: Normal
* Assignee: Hiroshi Nakamura
* Category: lib
* Target version: current: 2.2.0
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:93887] [Ruby master Feature#9532] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
` (3 preceding siblings ...)
2014-08-13 2:49 ` [ruby-core:64344] [ruby-trunk - Feature #9532] [Feedback] " shibata.hiroshi
@ 2019-07-23 15:10 ` hsbt
2019-08-17 3:42 ` [ruby-core:94397] " sonots
5 siblings, 0 replies; 6+ messages in thread
From: hsbt @ 2019-07-23 15:10 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been updated by hsbt (Hiroshi SHIBATA).
Assignee changed from nahi (Hiroshi Nakamura) to sonots (Naotoshi Seo)
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532#change-79870
* Author: arthurnn (Arthur Neves)
* Status: Feedback
* Priority: Normal
* Assignee: sonots (Naotoshi Seo)
* Target version:
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:94397] [Ruby master Feature#9532] Expose logger monitor
[not found] <redmine.issue-9532.20140218221101@ruby-lang.org>
` (4 preceding siblings ...)
2019-07-23 15:10 ` [ruby-core:93887] [Ruby master Feature#9532] " hsbt
@ 2019-08-17 3:42 ` sonots
5 siblings, 0 replies; 6+ messages in thread
From: sonots @ 2019-08-17 3:42 UTC (permalink / raw)
To: ruby-core
Issue #9532 has been updated by sonots (Naotoshi Seo).
This is already fixed via https://github.com/ruby/ruby/pull/541
----------------------------------------
Feature #9532: Expose logger monitor
https://bugs.ruby-lang.org/issues/9532#change-80815
* Author: arthurnn (Arthur Neves)
* Status: Feedback
* Priority: Normal
* Assignee: sonots (Naotoshi Seo)
* Target version:
----------------------------------------
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread