From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 2AB5117D9D46 for ; Wed, 13 Aug 2014 12:12:44 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 64AF1B5D8EF for ; Wed, 13 Aug 2014 11:49:59 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id C06BB97A854 for ; Wed, 13 Aug 2014 11:50:00 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BOpW6pfr8Kdq for ; Wed, 13 Aug 2014 11:50:00 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 781EA97A841 for ; Wed, 13 Aug 2014 11:50:00 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 8A69C95249F for ; Wed, 13 Aug 2014 11:49:58 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B49E9120443; Wed, 13 Aug 2014 11:49:45 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id E672312042A for ; Wed, 13 Aug 2014 11:49:41 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=NLg4jAP39W0tKVwjkPTB0V3I/iw=; b=PALtNCOZOde+QfCali F1oupKiMq5Q2S20YUKGTQBHQZ77derW8HgZErMBj6z5adAh/Dg7SkPEBsu+xJ7sF V2uECDvegHHdkv5ctxK9B6sjgUV/cG/8e9/5ws5KZt6/FnglnKcgJ265gIO96+Pc oBPksmOckUqYMxFc3mUgDZV7k= Received: by mf183.sendgrid.net with SMTP id mf183.7640.53EAD24210 2014-08-13 02:49:39.233968778 +0000 UTC Received: from herokuapp.com (ec2-54-82-50-28.compute-1.amazonaws.com [54.82.50.28]) by ismtpd-016.iad1.sendgrid.net (SG) with ESMTP id 147cd45563d.67e.2e8acb for ; Wed, 13 Aug 2014 02:49:39 +0000 (GMT) Date: Wed, 13 Aug 2014 02:49:38 +0000 From: shibata.hiroshi@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 38510 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 9532 X-Redmine-Issue-Author: arthurnn X-Redmine-Issue-Assignee: nahi X-Redmine-Sender: hsbt X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5bRUt/+5F1QUzo1Qr0JKqC9O5kAkJoZVyU3uwzbxbaHYpjS2XgyhSXI+iC8Y1neab5UgbefjYmYTy2+J0dcXvFGPbEfOQzP+9S3I30Pxk0ioNVJqmAkxE0TMxaMKHlEbY= X-ML-Name: ruby-core X-Mail-Count: 64344 Subject: [ruby-core:64344] [ruby-trunk - Feature #9532] [Feedback] Expose logger monitor X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #9532 has been updated by Hiroshi SHIBATA. Status changed from Assigned to Feedback Your patch broke logger and syslog/logger tests. ---------------------------------------- Feature #9532: Expose logger monitor https://bugs.ruby-lang.org/issues/9532#change-48324 * Author: Arthur Neves * Status: Feedback * Priority: Normal * Assignee: Hiroshi Nakamura * Category: lib * Target version: current: 2.2.0 ---------------------------------------- I was wondering if we could do this type of change on the logger class: https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe. -- https://bugs.ruby-lang.org/