[ruby-core:99127] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[ruby-core:99127] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[mail]

Issue #17024 has been reported by timcraft (Tim Craft).

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024

* Author: timcraft (Tim Craft)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:99128] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[mail]

Issue #17024 has been updated by timcraft (Tim Craft).


For example:
```
$ irb -r tzinfo
irb(main):001:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).wday
=> 7
irb(main):002:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).yday
=> 0
```

(The wday should be 3, and the yday should be 1.)

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024#change-86504

* Author: timcraft (Tim Craft)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:99137] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[nobu]

Issue #17024 has been updated by nobu (Nobuyoshi Nakada).

Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN to 2.5: DONTNEED, 2.6: REQUIRED, 2.7: REQUIRED

https://github.com/ruby/ruby/pull/3312

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024#change-86514

* Author: timcraft (Tim Craft)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: DONTNEED, 2.6: REQUIRED, 2.7: REQUIRED
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:99284] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[nagachika00]

Issue #17024 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.5: DONTNEED, 2.6: REQUIRED, 2.7: REQUIRED to 2.5: DONTNEED, 2.6: REQUIRED, 2.7: DONE

ruby_2_7 4be9bf1f67b997fc519625d56a93b8a68a70d124 merged revision(s) 99a9c3fe2eaab8157765d792dc871da6daea0327.

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024#change-86671

* Author: timcraft (Tim Craft)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: DONTNEED, 2.6: REQUIRED, 2.7: DONE
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:102712] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[usa]

Issue #17024 has been updated by usa (Usaku NAKAMURA).

Backport changed from 2.5: DONTNEED, 2.6: REQUIRED, 2.7: DONE to 2.5: DONTNEED, 2.6: DONE, 2.7: DONE

backport into ruby_2_6 at r67911.

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024#change-90706

* Author: timcraft (Tim Craft)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: DONTNEED, 2.6: DONE, 2.7: DONE
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/