[ruby-core:99128] [Ruby master Bug#17024] Times with timezones return incorrect wday and yday

[mail@timcraft.com]

Issue #17024 has been updated by timcraft (Tim Craft).


For example:
```
$ irb -r tzinfo
irb(main):001:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).wday
=> 7
irb(main):002:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).yday
=> 0
```

(The wday should be 3, and the yday should be 1.)

----------------------------------------
Bug #17024: Times with timezones return incorrect wday and yday
https://bugs.ruby-lang.org/issues/17024#change-86504

* Author: timcraft (Tim Craft)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.

I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/ruby/ruby/commit/ee58c638b8d10d2ea10faadbc7b34515d2f2e351) it looks like `vtm->wday` and `vtm->yday` are both set by `vtm_add_offset`, and that isn't called with the [new block of code which handles the timezone](https://github.com/ruby/ruby/blob/ee58c638b8d10d2ea10faadbc7b34515d2f2e351/time.c#L2261-L2272).

I've attached a patch to the tests and specs which demonstrates the bug.


---Files--------------------------------
patch.diff (1.03 KB)


-- 
https://bugs.ruby-lang.org/