* [ruby-core:95480] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2
[not found] <redmine.issue-16271.20191022214155@ruby-lang.org>
@ 2019-10-22 21:41 ` merch-redmine
2019-10-23 3:25 ` [ruby-core:95488] " shyouhei
2019-10-23 4:21 ` [ruby-core:95489] " merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: merch-redmine @ 2019-10-22 21:41 UTC (permalink / raw)
To: ruby-core
Issue #16271 has been reported by jeremyevans0 (Jeremy Evans).
----------------------------------------
Bug #16271: Cannot build taglib-ruby gem on ruby-2.7.0-preview2
https://bugs.ruby-lang.org/issues/16271
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: shyouhei (Shyouhei Urabe)
* Target version:
* ruby -v: ruby 2.7.0preview2 (2019-10-22 master 02aadf1032) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED
----------------------------------------
Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:
```
taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2ULONG), (VALUE)a, RUBY_METHOD_FUNC(SWIG_ruby_failed), 0) != Qnil) {
^~~~~~~~~
/usr/local/include/ruby-2.7/ruby/ruby.h:1989:7: note: candidate function not viable: no known conversion from 'VALUE (VALUE *)' (aka 'unsigned long (unsigned long *)') to 'VALUE (*)(VALUE)' (aka 'unsigned long (*)(unsigned long)') for 1st argument
VALUE rb_rescue(VALUE(*)(VALUE),VALUE,VALUE(*)(VALUE,VALUE),VALUE);
```
I believe this is related to the CXX/ANYARGS changes made between ruby-2.7.0-preview1 and preview2. I was not aware these were expected to cause backwards compatibility issues, which is why I'm submitting the bug report here.
I believe taglib-ruby uses code generated via SWIG. I'm not sure if SWIG needs to be adjusted, or if the issue is related to the use of SWIG.
This may be a problem in the gem and not in our CXX handling. In that case, please let me know and I will post an issue in the gem's tracker.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:95488] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2
[not found] <redmine.issue-16271.20191022214155@ruby-lang.org>
2019-10-22 21:41 ` [ruby-core:95480] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2 merch-redmine
@ 2019-10-23 3:25 ` shyouhei
2019-10-23 4:21 ` [ruby-core:95489] " merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: shyouhei @ 2019-10-23 3:25 UTC (permalink / raw)
To: ruby-core
Issue #16271 has been updated by shyouhei (Shyouhei Urabe).
Assignee changed from shyouhei (Shyouhei Urabe) to nobu (Nobuyoshi Nakada)
jeremyevans0 (Jeremy Evans) wrote:
> Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:
>
> ```
> taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
> if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2ULONG), (VALUE)a, RUBY_METHOD_FUNC(SWIG_ruby_failed), 0) != Qnil) {
> ^~~~~~~~~
> /usr/local/include/ruby-2.7/ruby/ruby.h:1989:7: note: candidate function not viable: no known conversion from 'VALUE (VALUE *)' (aka 'unsigned long (unsigned long *)') to 'VALUE (*)(VALUE)' (aka 'unsigned long (*)(unsigned long)') for 1st argument
> VALUE rb_rescue(VALUE(*)(VALUE),VALUE,VALUE(*)(VALUE,VALUE),VALUE);
> ```
>
> I believe this is related to the CXX/ANYARGS changes made between ruby-2.7.0-preview1 and preview2. I was not aware these were expected to cause backwards compatibility issues, which is why I'm submitting the bug report here.
>
> I believe taglib-ruby uses code generated via SWIG. I'm not sure if SWIG needs to be adjusted, or if the issue is related to the use of SWIG.
>
> This may be a problem in the gem and not in our CXX handling. In that case, please let me know and I will post an issue in the gem's tracker.
Well, it seems the function called `SWIG_ruby_failed` is prototyped as `VALUE SWIG_ruby_failed(void)` (source: https://github.com/swig/swig/blob/master/Lib/ruby/rubyprimtypes.swg).
However the third argument of `rb_rescue()` is `VALUE (*)(VALUE, VALUE)` (source: ruby.h).
So yes, the API change _revealed_ an arity mismatch here. `SWIG_ruby_failed` is getting more arguments than it expects, which is dangerous depending on machine ABI. It has to be fixed. I believe it's SWIG, not the gem, wihch has to handle this.
----------------------------------------
Bug #16271: Cannot build taglib-ruby gem on ruby-2.7.0-preview2
https://bugs.ruby-lang.org/issues/16271#change-82259
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* Target version:
* ruby -v: ruby 2.7.0preview2 (2019-10-22 master 02aadf1032) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED
----------------------------------------
Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:
```
taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2ULONG), (VALUE)a, RUBY_METHOD_FUNC(SWIG_ruby_failed), 0) != Qnil) {
^~~~~~~~~
/usr/local/include/ruby-2.7/ruby/ruby.h:1989:7: note: candidate function not viable: no known conversion from 'VALUE (VALUE *)' (aka 'unsigned long (unsigned long *)') to 'VALUE (*)(VALUE)' (aka 'unsigned long (*)(unsigned long)') for 1st argument
VALUE rb_rescue(VALUE(*)(VALUE),VALUE,VALUE(*)(VALUE,VALUE),VALUE);
```
I believe this is related to the CXX/ANYARGS changes made between ruby-2.7.0-preview1 and preview2. I was not aware these were expected to cause backwards compatibility issues, which is why I'm submitting the bug report here.
I believe taglib-ruby uses code generated via SWIG. I'm not sure if SWIG needs to be adjusted, or if the issue is related to the use of SWIG.
This may be a problem in the gem and not in our CXX handling. In that case, please let me know and I will post an issue in the gem's tracker.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:95489] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2
[not found] <redmine.issue-16271.20191022214155@ruby-lang.org>
2019-10-22 21:41 ` [ruby-core:95480] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2 merch-redmine
2019-10-23 3:25 ` [ruby-core:95488] " shyouhei
@ 2019-10-23 4:21 ` merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: merch-redmine @ 2019-10-23 4:21 UTC (permalink / raw)
To: ruby-core
Issue #16271 has been updated by jeremyevans0 (Jeremy Evans).
shyouhei (Shyouhei Urabe) wrote:
> So yes, the API change _revealed_ an arity mismatch here. `SWIG_ruby_failed` is getting more arguments than it expects, which is dangerous depending on machine ABI. It has to be fixed. I believe it's SWIG, not the gem, wihch has to handle this.
@shyouhei , thank you very much for your quick analysis. I have posted this bug upstream (https://github.com/robinst/taglib-ruby/issues/85), though they probably need to wait for a SWIG update to fix it.
This can probably be closed unless @shyouhei or @nobu would like it to remain open.
----------------------------------------
Bug #16271: Cannot build taglib-ruby gem on ruby-2.7.0-preview2
https://bugs.ruby-lang.org/issues/16271#change-82260
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* Target version:
* ruby -v: ruby 2.7.0preview2 (2019-10-22 master 02aadf1032) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED
----------------------------------------
Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:
```
taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2ULONG), (VALUE)a, RUBY_METHOD_FUNC(SWIG_ruby_failed), 0) != Qnil) {
^~~~~~~~~
/usr/local/include/ruby-2.7/ruby/ruby.h:1989:7: note: candidate function not viable: no known conversion from 'VALUE (VALUE *)' (aka 'unsigned long (unsigned long *)') to 'VALUE (*)(VALUE)' (aka 'unsigned long (*)(unsigned long)') for 1st argument
VALUE rb_rescue(VALUE(*)(VALUE),VALUE,VALUE(*)(VALUE,VALUE),VALUE);
```
I believe this is related to the CXX/ANYARGS changes made between ruby-2.7.0-preview1 and preview2. I was not aware these were expected to cause backwards compatibility issues, which is why I'm submitting the bug report here.
I believe taglib-ruby uses code generated via SWIG. I'm not sure if SWIG needs to be adjusted, or if the issue is related to the use of SWIG.
This may be a problem in the gem and not in our CXX handling. In that case, please let me know and I will post an issue in the gem's tracker.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-23 4:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <redmine.issue-16271.20191022214155@ruby-lang.org>
2019-10-22 21:41 ` [ruby-core:95480] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2 merch-redmine
2019-10-23 3:25 ` [ruby-core:95488] " shyouhei
2019-10-23 4:21 ` [ruby-core:95489] " merch-redmine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).