ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: merch-redmine@jeremyevans.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95489] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2
Date: Wed, 23 Oct 2019 04:21:54 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-82260.20191023042154.cf0fb6b828ee5806@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16271.20191022214155@ruby-lang.org

Issue #16271 has been updated by jeremyevans0 (Jeremy Evans).


shyouhei (Shyouhei Urabe) wrote:
> So yes, the API change _revealed_ an arity mismatch here.  `SWIG_ruby_failed` is getting more arguments than it expects, which is dangerous depending on machine ABI.  It has to be fixed.  I believe it's SWIG, not the gem, wihch has to handle this.

@shyouhei , thank you very much for your quick analysis.  I have posted this bug upstream (https://github.com/robinst/taglib-ruby/issues/85), though they probably need to wait for a SWIG update to fix it.

This can probably be closed unless @shyouhei or @nobu would like it to remain open.

----------------------------------------
Bug #16271: Cannot build taglib-ruby gem on ruby-2.7.0-preview2
https://bugs.ruby-lang.org/issues/16271#change-82260

* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* Target version: 
* ruby -v: ruby 2.7.0preview2 (2019-10-22 master 02aadf1032) [x86_64-openbsd]
* Backport: 2.5: DONTNEED, 2.6: DONTNEED
----------------------------------------
Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:

```
taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
    if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2ULONG), (VALUE)a, RUBY_METHOD_FUNC(SWIG_ruby_failed), 0) != Qnil) {
            ^~~~~~~~~
            /usr/local/include/ruby-2.7/ruby/ruby.h:1989:7: note: candidate function not viable: no known conversion from 'VALUE (VALUE *)' (aka 'unsigned long (unsigned long *)') to 'VALUE (*)(VALUE)' (aka 'unsigned long (*)(unsigned long)') for 1st argument
            VALUE rb_rescue(VALUE(*)(VALUE),VALUE,VALUE(*)(VALUE,VALUE),VALUE);
```

I believe this is related to the CXX/ANYARGS changes made between ruby-2.7.0-preview1 and preview2.  I was not aware these were expected to cause backwards compatibility issues, which is why I'm submitting the bug report here.

I believe taglib-ruby uses code generated via SWIG.  I'm not sure if SWIG needs to be adjusted, or if the issue is related to the use of SWIG.

This may be a problem in the gem and not in our CXX handling.  In that case, please let me know and I will post an issue in the gem's tracker.



-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2019-10-23  4:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16271.20191022214155@ruby-lang.org>
2019-10-22 21:41 ` [ruby-core:95480] [Ruby master Bug#16271] Cannot build taglib-ruby gem on ruby-2.7.0-preview2 merch-redmine
2019-10-23  3:25 ` [ruby-core:95488] " shyouhei
2019-10-23  4:21 ` merch-redmine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-82260.20191023042154.cf0fb6b828ee5806@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).