ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:92567] [Ruby trunk Bug#15832] IPAddr.new accepts invalid mask IP address
       [not found] <redmine.issue-15832.20190505205228@ruby-lang.org>
@ 2019-05-05 20:52 ` lay20114
  2019-06-05  2:02 ` [ruby-core:92967] " merch-redmine
  2019-07-09  6:55 ` [ruby-core:93630] [Ruby master " samuel
  2 siblings, 0 replies; 3+ messages in thread
From: lay20114 @ 2019-05-05 20:52 UTC (permalink / raw)
  To: ruby-core

Issue #15832 has been reported by tsuna (Kenta Tsuna).

----------------------------------------
Bug #15832: IPAddr.new accepts invalid mask IP address
https://bugs.ruby-lang.org/issues/15832

* Author: tsuna (Kenta Tsuna)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-05-05 trunk 594a033ff0) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
IPAddr.new accepts IP address with multiple mask and/or zero padded one.
```
$ cat ipaddr.rb
require 'ipaddr'

addrs = %w[192.0.2.0/24/16
           192.0.2.0/00024
           192.0.2.0/24/00016
           192.0.2.0/00024/16
           2001:db8::/32/24
           2001:db8::/00032
           2001:db8::/32/00024
           2001:db8::/00032/24]

addrs.each do |addr|
  begin
    p IPAddr.new(addr)
    puts "#{addr} is valid"
  rescue StandardError
    puts "#{addr} is invalid"
  end
end
```
```
$ ruby ipaddr.rb
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/16 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/00016 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024/16 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/24 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/00024 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032/24 is valid
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:92967] [Ruby trunk Bug#15832] IPAddr.new accepts invalid mask IP address
       [not found] <redmine.issue-15832.20190505205228@ruby-lang.org>
  2019-05-05 20:52 ` [ruby-core:92567] [Ruby trunk Bug#15832] IPAddr.new accepts invalid mask IP address lay20114
@ 2019-06-05  2:02 ` merch-redmine
  2019-07-09  6:55 ` [ruby-core:93630] [Ruby master " samuel
  2 siblings, 0 replies; 3+ messages in thread
From: merch-redmine @ 2019-06-05  2:02 UTC (permalink / raw)
  To: ruby-core

Issue #15832 has been updated by jeremyevans0 (Jeremy Evans).

Assignee set to knu (Akinori MUSHA)
Status changed from Open to Assigned

I submitted a pull request to ruby/ipaddr to fix this: https://github.com/ruby/ipaddr/pull/17

----------------------------------------
Bug #15832: IPAddr.new accepts invalid mask IP address
https://bugs.ruby-lang.org/issues/15832#change-78345

* Author: tsuna (Kenta Tsuna)
* Status: Assigned
* Priority: Normal
* Assignee: knu (Akinori MUSHA)
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-05-05 trunk 594a033ff0) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
IPAddr.new accepts IP address with multiple mask and/or zero padded one.
```
$ cat ipaddr.rb
require 'ipaddr'

addrs = %w[192.0.2.0/24/16
           192.0.2.0/00024
           192.0.2.0/24/00016
           192.0.2.0/00024/16
           2001:db8::/32/24
           2001:db8::/00032
           2001:db8::/32/00024
           2001:db8::/00032/24]

addrs.each do |addr|
  begin
    p IPAddr.new(addr)
    puts "#{addr} is valid"
  rescue StandardError
    puts "#{addr} is invalid"
  end
end
```
```
$ ruby ipaddr.rb
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/16 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/00016 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024/16 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/24 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/00024 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032/24 is valid
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:93630] [Ruby master Bug#15832] IPAddr.new accepts invalid mask IP address
       [not found] <redmine.issue-15832.20190505205228@ruby-lang.org>
  2019-05-05 20:52 ` [ruby-core:92567] [Ruby trunk Bug#15832] IPAddr.new accepts invalid mask IP address lay20114
  2019-06-05  2:02 ` [ruby-core:92967] " merch-redmine
@ 2019-07-09  6:55 ` samuel
  2 siblings, 0 replies; 3+ messages in thread
From: samuel @ 2019-07-09  6:55 UTC (permalink / raw)
  To: ruby-core

Issue #15832 has been updated by ioquatix (Samuel Williams).

Status changed from Assigned to Closed

I merged it.

----------------------------------------
Bug #15832: IPAddr.new accepts invalid mask IP address
https://bugs.ruby-lang.org/issues/15832#change-79238

* Author: tsuna (Kenta Tsuna)
* Status: Closed
* Priority: Normal
* Assignee: knu (Akinori MUSHA)
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-05-05 trunk 594a033ff0) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
IPAddr.new accepts IP address with multiple mask and/or zero padded one.
```
$ cat ipaddr.rb
require 'ipaddr'

addrs = %w[192.0.2.0/24/16
           192.0.2.0/00024
           192.0.2.0/24/00016
           192.0.2.0/00024/16
           2001:db8::/32/24
           2001:db8::/00032
           2001:db8::/32/00024
           2001:db8::/00032/24]

addrs.each do |addr|
  begin
    p IPAddr.new(addr)
    puts "#{addr} is valid"
  rescue StandardError
    puts "#{addr} is invalid"
  end
end
```
```
$ ruby ipaddr.rb
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/16 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/24/00016 is valid
#<IPAddr: IPv4:192.0.2.0/255.255.255.0>
192.0.2.0/00024/16 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/24 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/32/00024 is valid
#<IPAddr: IPv6:2001:0db8:0000:0000:0000:0000:0000:0000/ffff:ffff:0000:0000:0000:0000:0000:0000>
2001:db8::/00032/24 is valid
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-09  6:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-15832.20190505205228@ruby-lang.org>
2019-05-05 20:52 ` [ruby-core:92567] [Ruby trunk Bug#15832] IPAddr.new accepts invalid mask IP address lay20114
2019-06-05  2:02 ` [ruby-core:92967] " merch-redmine
2019-07-09  6:55 ` [ruby-core:93630] [Ruby master " samuel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).