From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E60401F461 for ; Tue, 9 Jul 2019 06:55:10 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2C5F8120A7B; Tue, 9 Jul 2019 15:55:05 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 3927F120A77 for ; Tue, 9 Jul 2019 15:55:03 +0900 (JST) Received: by filter0191p3mdw1.sendgrid.net with SMTP id filter0191p3mdw1-9016-5D243A49-23 2019-07-09 06:55:05.735794643 +0000 UTC m=+480248.554894632 Received: from herokuapp.com (unknown [54.91.81.97]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id RxGvVLhnRXyrco2DLdeYRw for ; Tue, 09 Jul 2019 06:55:05.694 +0000 (UTC) Date: Tue, 09 Jul 2019 06:55:05 +0000 (UTC) From: samuel@oriontransfer.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 69125 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15832 X-Redmine-Issue-Author: tsuna X-Redmine-Issue-Assignee: knu X-Redmine-Sender: ioquatix X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?cjxb6GWHefMLoR50bkJBcGo6DRiDl=2FNYcMZdY+Wj30SvMEx=2FslaaGhr5BsaMTW?= =?us-ascii?Q?KfIjVIzRrwoHgc=2FWTBaX4p0UCWvIai0353oUza3?= =?us-ascii?Q?Q5WPD48EIm96hXaJ0wr7LCgwjD9Eq4eMM=2F92eHa?= =?us-ascii?Q?WWVOVyE19ZSW36QcN8mFtiHrsioLGhrKSzB+Uw=2F?= =?us-ascii?Q?NQu53qkLGgWwUh6U65bi9QufrPNGytQDUIg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 93630 Subject: [ruby-core:93630] [Ruby master Bug#15832] IPAddr.new accepts invalid mask IP address X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15832 has been updated by ioquatix (Samuel Williams). Status changed from Assigned to Closed I merged it. ---------------------------------------- Bug #15832: IPAddr.new accepts invalid mask IP address https://bugs.ruby-lang.org/issues/15832#change-79238 * Author: tsuna (Kenta Tsuna) * Status: Closed * Priority: Normal * Assignee: knu (Akinori MUSHA) * Target version: * ruby -v: ruby 2.7.0dev (2019-05-05 trunk 594a033ff0) [x86_64-linux] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- IPAddr.new accepts IP address with multiple mask and/or zero padded one. ``` $ cat ipaddr.rb require 'ipaddr' addrs = %w[192.0.2.0/24/16 192.0.2.0/00024 192.0.2.0/24/00016 192.0.2.0/00024/16 2001:db8::/32/24 2001:db8::/00032 2001:db8::/32/00024 2001:db8::/00032/24] addrs.each do |addr| begin p IPAddr.new(addr) puts "#{addr} is valid" rescue StandardError puts "#{addr} is invalid" end end ``` ``` $ ruby ipaddr.rb # 192.0.2.0/24/16 is valid # 192.0.2.0/00024 is valid # 192.0.2.0/24/00016 is valid # 192.0.2.0/00024/16 is valid # 2001:db8::/32/24 is valid # 2001:db8::/00032 is valid # 2001:db8::/32/00024 is valid # 2001:db8::/00032/24 is valid ``` -- https://bugs.ruby-lang.org/