ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:81557] [Ruby trunk Bug#13629] Improve performance in where copy array elements
       [not found] <redmine.issue-13629.20170603095408@ruby-lang.org>
@ 2017-06-03  9:54 ` watson1978
  2017-06-03 12:30 ` [ruby-core:81560] [Ruby trunk Bug#13629][Rejected] Improve performance for copying " nobu
  1 sibling, 0 replies; 2+ messages in thread
From: watson1978 @ 2017-06-03  9:54 UTC (permalink / raw)
  To: ruby-core

Issue #13629 has been reported by watson1978 (Shizuo Fujita).

----------------------------------------
Bug #13629: Improve performance in where copy array elements
https://bugs.ruby-lang.org/issues/13629

* Author: watson1978 (Shizuo Fujita)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
ary_memcpy0() has calculated the cache line size every time when copy array elements.
This patch will replace it with pre calculated value of cache line size.

Array#+ will be faster around 2%.

### Before
~~~
      Array#+(other)      5.167M (± 0.1%) i/s -     25.928M in   5.017629s
~~~

### After
~~~
      Array#+(other)      5.256M (± 0.2%) i/s -     26.410M in   5.025261s
~~~

### Test code
~~~
require 'benchmark/ips'

Benchmark.ips do |x|
  x.report "Array#+(other)" do |loop|
    ary1 = [1, 2, 3]
    ary2 = [4, 5]
    i = 0
    while i < loop
      ary1 + ary2
      i += 1
    end
  end
end
~~~

### Patch
https://github.com/ruby/ruby/pull/1641



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [ruby-core:81560] [Ruby trunk Bug#13629][Rejected] Improve performance for copying array elements
       [not found] <redmine.issue-13629.20170603095408@ruby-lang.org>
  2017-06-03  9:54 ` [ruby-core:81557] [Ruby trunk Bug#13629] Improve performance in where copy array elements watson1978
@ 2017-06-03 12:30 ` nobu
  1 sibling, 0 replies; 2+ messages in thread
From: nobu @ 2017-06-03 12:30 UTC (permalink / raw)
  To: ruby-core

Issue #13629 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Open to Rejected

Nothing changed actually.

----------------------------------------
Bug #13629: Improve performance for copying array elements
https://bugs.ruby-lang.org/issues/13629#change-65263

* Author: watson1978 (Shizuo Fujita)
* Status: Rejected
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
ary_memcpy0() has calculated the cache line size every time when copy array elements.
This patch will replace it with pre calculated value of cache line size.

Array#+ will be faster around 2%.

### Before
~~~
      Array#+(other)      5.167M (± 0.1%) i/s -     25.928M in   5.017629s
~~~

### After
~~~
      Array#+(other)      5.256M (± 0.2%) i/s -     26.410M in   5.025261s
~~~

### Test code
~~~
require 'benchmark/ips'

Benchmark.ips do |x|
  x.report "Array#+(other)" do |loop|
    ary1 = [1, 2, 3]
    ary2 = [4, 5]
    i = 0
    while i < loop
      ary1 + ary2
      i += 1
    end
  end
end
~~~

### Patch
https://github.com/ruby/ruby/pull/1641



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-03 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-13629.20170603095408@ruby-lang.org>
2017-06-03  9:54 ` [ruby-core:81557] [Ruby trunk Bug#13629] Improve performance in where copy array elements watson1978
2017-06-03 12:30 ` [ruby-core:81560] [Ruby trunk Bug#13629][Rejected] Improve performance for copying " nobu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).