From: nobu@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:81560] [Ruby trunk Bug#13629][Rejected] Improve performance for copying array elements
Date: Sat, 03 Jun 2017 12:30:31 +0000 [thread overview]
Message-ID: <redmine.journal-65263.20170603123030.e8622bc9b7ed513b@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-13629.20170603095408@ruby-lang.org
Issue #13629 has been updated by nobu (Nobuyoshi Nakada).
Status changed from Open to Rejected
Nothing changed actually.
----------------------------------------
Bug #13629: Improve performance for copying array elements
https://bugs.ruby-lang.org/issues/13629#change-65263
* Author: watson1978 (Shizuo Fujita)
* Status: Rejected
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
ary_memcpy0() has calculated the cache line size every time when copy array elements.
This patch will replace it with pre calculated value of cache line size.
Array#+ will be faster around 2%.
### Before
~~~
Array#+(other) 5.167M (± 0.1%) i/s - 25.928M in 5.017629s
~~~
### After
~~~
Array#+(other) 5.256M (± 0.2%) i/s - 26.410M in 5.025261s
~~~
### Test code
~~~
require 'benchmark/ips'
Benchmark.ips do |x|
x.report "Array#+(other)" do |loop|
ary1 = [1, 2, 3]
ary2 = [4, 5]
i = 0
while i < loop
ary1 + ary2
i += 1
end
end
end
~~~
### Patch
https://github.com/ruby/ruby/pull/1641
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2017-06-03 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-13629.20170603095408@ruby-lang.org>
2017-06-03 9:54 ` [ruby-core:81557] [Ruby trunk Bug#13629] Improve performance in where copy array elements watson1978
2017-06-03 12:30 ` nobu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-65263.20170603123030.e8622bc9b7ed513b@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).