[ruby-core:71466] [Ruby trunk - Misc #11681] [Open] Refinements documentation is based on older implementation

[ruby-core:71466] [Ruby trunk - Misc #11681] [Open] Refinements documentation is based on older implementation

[james]

Issue #11681 has been reported by James Adam.

----------------------------------------
Misc #11681: Refinements documentation is based on older implementation
https://bugs.ruby-lang.org/issues/11681

* Author: James Adam
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
It seems that the refinements documentation hasn't been updated to reflect more recent changes to how refinements work. For example, [[https://github.com/ruby/ruby/blob/trunk/doc/syntax/refinements.rdoc#scope]] says "You may only activate refinements at top-level, not inside any class, module or method scope", whereas the current implementation allows activating refinements anywhere except inside methods.

I've attached one potential reworking to be more accurate, but I don't mind if it's used or not. The main thing is for it to be made correct.

---Files--------------------------------
update-refinements-documentation.patch (2.63 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:71518] [Ruby trunk - Misc #11681] [Assigned] Refinements documentation is based on older implementation

[shibata.hiroshi]

Issue #11681 has been updated by Hiroshi SHIBATA.

Status changed from Open to Assigned
Assignee set to Shugo Maeda

----------------------------------------
Misc #11681: Refinements documentation is based on older implementation
https://bugs.ruby-lang.org/issues/11681#change-54893

* Author: James Adam
* Status: Assigned
* Priority: Normal
* Assignee: Shugo Maeda
----------------------------------------
It seems that the refinements documentation hasn't been updated to reflect more recent changes to how refinements work. For example, [[https://github.com/ruby/ruby/blob/trunk/doc/syntax/refinements.rdoc#scope]] says "You may only activate refinements at top-level, not inside any class, module or method scope", whereas the current implementation allows activating refinements anywhere except inside methods.

I've attached one potential reworking to be more accurate, but I don't mind if it's used or not. The main thing is for it to be made correct.

---Files--------------------------------
update-refinements-documentation.patch (2.63 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:71604] [Ruby trunk - Misc #11681] [Closed] Refinements documentation is based on older implementation

[shugo]

Issue #11681 has been updated by Shugo Maeda.

Status changed from Assigned to Closed

Merged by r52629

----------------------------------------
Misc #11681: Refinements documentation is based on older implementation
https://bugs.ruby-lang.org/issues/11681#change-54988

* Author: James Adam
* Status: Closed
* Priority: Normal
* Assignee: Shugo Maeda
----------------------------------------
It seems that the refinements documentation hasn't been updated to reflect more recent changes to how refinements work. For example, [[https://github.com/ruby/ruby/blob/trunk/doc/syntax/refinements.rdoc#scope]] says "You may only activate refinements at top-level, not inside any class, module or method scope", whereas the current implementation allows activating refinements anywhere except inside methods.

I've attached one potential reworking to be more accurate, but I don't mind if it's used or not. The main thing is for it to be made correct.

---Files--------------------------------
update-refinements-documentation.patch (2.63 KB)


-- 
https://bugs.ruby-lang.org/