ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: shugo@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:71604] [Ruby trunk - Misc #11681] [Closed] Refinements documentation is based on older implementation
Date: Fri, 20 Nov 2015 07:37:59 +0000	[thread overview]
Message-ID: <redmine.journal-54988.20151120073759.891f08341b13774a@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11681.20151112201505@ruby-lang.org

Issue #11681 has been updated by Shugo Maeda.

Status changed from Assigned to Closed

Merged by r52629

----------------------------------------
Misc #11681: Refinements documentation is based on older implementation
https://bugs.ruby-lang.org/issues/11681#change-54988

* Author: James Adam
* Status: Closed
* Priority: Normal
* Assignee: Shugo Maeda
----------------------------------------
It seems that the refinements documentation hasn't been updated to reflect more recent changes to how refinements work. For example, [[https://github.com/ruby/ruby/blob/trunk/doc/syntax/refinements.rdoc#scope]] says "You may only activate refinements at top-level, not inside any class, module or method scope", whereas the current implementation allows activating refinements anywhere except inside methods.

I've attached one potential reworking to be more accurate, but I don't mind if it's used or not. The main thing is for it to be made correct.

---Files--------------------------------
update-refinements-documentation.patch (2.63 KB)


-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2015-11-20  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-11681.20151112201505@ruby-lang.org>
2015-11-12 20:15 ` [ruby-core:71466] [Ruby trunk - Misc #11681] [Open] Refinements documentation is based on older implementation james
2015-11-17  9:06 ` [ruby-core:71518] [Ruby trunk - Misc #11681] [Assigned] " shibata.hiroshi
2015-11-20  7:37 ` shugo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-54988.20151120073759.891f08341b13774a@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).