* [ruby-core:68384] [Ruby trunk - Bug #10929] [Open] NilClass#to_proc and & don't mix?
[not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
@ 2015-03-02 23:43 ` transfire
2015-03-06 13:00 ` [ruby-core:68440] [Ruby trunk - Bug #10929] " hanachin
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: transfire @ 2015-03-02 23:43 UTC (permalink / raw)
To: ruby-core
Issue #10929 has been reported by Thomas Sawyer.
----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929
* Author: Thomas Sawyer
* Status: Open
* Priority: Low
* Assignee:
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.
~~~
class NilClass
def to_proc
Proc.new{ |*x| nil }
end
end
def f(&b)
b.call(1)
end
f(&nil)
=> NoMethodError: undefined method `call' for nil:NilClass
~~~
(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:68440] [Ruby trunk - Bug #10929] NilClass#to_proc and & don't mix?
[not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
2015-03-02 23:43 ` [ruby-core:68384] [Ruby trunk - Bug #10929] [Open] NilClass#to_proc and & don't mix? transfire
@ 2015-03-06 13:00 ` hanachin
2015-03-08 22:43 ` [ruby-core:68462] " ko1
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: hanachin @ 2015-03-06 13:00 UTC (permalink / raw)
To: ruby-core
Issue #10929 has been updated by Seiei Higa.
File block_from_nil.patch added
I wrote a patch for this issue.
```diff
diff --git bootstraptest/test_block.rb bootstraptest/test_block.rb
index cdc5960..4347fdd 100644
--- bootstraptest/test_block.rb
+++ bootstraptest/test_block.rb
@@ -611,3 +611,17 @@ assert_equal 'ok', %q{
end
'ok'
}
+
+assert_equal 'ok', %q{
+ class NilClass
+ def to_proc
+ Proc.new {|x| x }
+ end
+ end
+
+ def foo(&blk)
+ blk.call('ok')
+ end
+
+ foo(&nil)
+}, '[ruby-core:68384] [Bug #10929]'
diff --git vm_args.c vm_args.c
index cf7256b..e1cb8ac 100644
--- vm_args.c
+++ vm_args.c
@@ -755,7 +755,7 @@ vm_caller_setup_arg_block(const rb_thread_t *th, rb_control_frame_t *reg_cfp, rb
proc = *(--reg_cfp->sp);
- if (proc != Qnil) {
+ if (proc != Qnil || rb_respond_to(Qnil, idTo_proc)) {
if (!rb_obj_is_proc(proc)) {
VALUE b;
```
----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929#change-51787
* Author: Thomas Sawyer
* Status: Open
* Priority: Low
* Assignee:
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.
~~~
class NilClass
def to_proc
Proc.new{ |*x| nil }
end
end
def f(&b)
b.call(1)
end
f(&nil)
=> NoMethodError: undefined method `call' for nil:NilClass
~~~
(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)
---Files--------------------------------
block_from_nil.patch (771 Bytes)
--
https://bugs.ruby-lang.org/
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [ruby-core:68462] [Ruby trunk - Bug #10929] NilClass#to_proc and & don't mix?
[not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
2015-03-02 23:43 ` [ruby-core:68384] [Ruby trunk - Bug #10929] [Open] NilClass#to_proc and & don't mix? transfire
2015-03-06 13:00 ` [ruby-core:68440] [Ruby trunk - Bug #10929] " hanachin
@ 2015-03-08 22:43 ` ko1
2019-12-16 15:15 ` [ruby-core:96270] [Ruby master Bug#10929] " mame
2020-01-14 2:31 ` [ruby-core:96829] " ko1
4 siblings, 0 replies; 5+ messages in thread
From: ko1 @ 2015-03-08 22:43 UTC (permalink / raw)
To: ruby-core
Issue #10929 has been updated by Koichi Sasada.
Assignee set to Yukihiro Matsumoto
I'm not sure we support it or not.
For me, it is easy to understand that passing `nil` is special case, passing no block.
----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929#change-51807
* Author: Thomas Sawyer
* Status: Open
* Priority: Low
* Assignee: Yukihiro Matsumoto
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.
~~~
class NilClass
def to_proc
Proc.new{ |*x| nil }
end
end
def f(&b)
b.call(1)
end
f(&nil)
=> NoMethodError: undefined method `call' for nil:NilClass
~~~
(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)
---Files--------------------------------
block_from_nil.patch (771 Bytes)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:96270] [Ruby master Bug#10929] NilClass#to_proc and & don't mix?
[not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
` (2 preceding siblings ...)
2015-03-08 22:43 ` [ruby-core:68462] " ko1
@ 2019-12-16 15:15 ` mame
2020-01-14 2:31 ` [ruby-core:96829] " ko1
4 siblings, 0 replies; 5+ messages in thread
From: mame @ 2019-12-16 15:15 UTC (permalink / raw)
To: ruby-core
Issue #10929 has been updated by mame (Yusuke Endoh).
Status changed from Open to Feedback
The suggested change is harmful. It will break delegation: `def foo(&blk); bar(&blk); end; foo()`.
Ruby allows redefinition of `Integer#/` which is incredibly harmful, so it is possible to allow `NilClass#to_proc`. But do you really want to allow that?
----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929#change-83169
* Author: trans (Thomas Sawyer)
* Status: Feedback
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version:
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.
~~~
class NilClass
def to_proc
Proc.new{ |*x| nil }
end
end
def f(&b)
b.call(1)
end
f(&nil)
=> NoMethodError: undefined method `call' for nil:NilClass
~~~
(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)
---Files--------------------------------
block_from_nil.patch (771 Bytes)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:96829] [Ruby master Bug#10929] NilClass#to_proc and & don't mix?
[not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
` (3 preceding siblings ...)
2019-12-16 15:15 ` [ruby-core:96270] [Ruby master Bug#10929] " mame
@ 2020-01-14 2:31 ` ko1
4 siblings, 0 replies; 5+ messages in thread
From: ko1 @ 2020-01-14 2:31 UTC (permalink / raw)
To: ruby-core
Issue #10929 has been updated by ko1 (Koichi Sasada).
Status changed from Feedback to Rejected
it can break delegation methods.
----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929#change-83828
* Author: trans (Thomas Sawyer)
* Status: Rejected
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version:
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.
~~~
class NilClass
def to_proc
Proc.new{ |*x| nil }
end
end
def f(&b)
b.call(1)
end
f(&nil)
=> NoMethodError: undefined method `call' for nil:NilClass
~~~
(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)
---Files--------------------------------
block_from_nil.patch (771 Bytes)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 5+ messages in thread