ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: hanachin@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:68440] [Ruby trunk - Bug #10929] NilClass#to_proc and & don't mix?
Date: Fri, 06 Mar 2015 13:00:48 +0000	[thread overview]
Message-ID: <redmine.journal-51787.20150306130048.d2b8ae79eb6fabf5@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-10929.20150302234342@ruby-lang.org

Issue #10929 has been updated by Seiei Higa.

File block_from_nil.patch added

I wrote a patch for this issue.

```diff
diff --git bootstraptest/test_block.rb bootstraptest/test_block.rb
index cdc5960..4347fdd 100644
--- bootstraptest/test_block.rb
+++ bootstraptest/test_block.rb
@@ -611,3 +611,17 @@ assert_equal 'ok', %q{
   end
   'ok'
 }
+
+assert_equal 'ok', %q{
+  class NilClass
+    def to_proc
+      Proc.new {|x| x }
+    end
+  end
+
+  def foo(&blk)
+    blk.call('ok')
+  end
+
+  foo(&nil)
+}, '[ruby-core:68384] [Bug #10929]'
diff --git vm_args.c vm_args.c
index cf7256b..e1cb8ac 100644
--- vm_args.c
+++ vm_args.c
@@ -755,7 +755,7 @@ vm_caller_setup_arg_block(const rb_thread_t *th, rb_control_frame_t *reg_cfp, rb

 	proc = *(--reg_cfp->sp);

-	if (proc != Qnil) {
+	if (proc != Qnil || rb_respond_to(Qnil, idTo_proc)) {
 	    if (!rb_obj_is_proc(proc)) {
 		VALUE b;
```

----------------------------------------
Bug #10929: NilClass#to_proc and & don't mix?
https://bugs.ruby-lang.org/issues/10929#change-51787

* Author: Thomas Sawyer
* Status: Open
* Priority: Low
* Assignee: 
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This is sort of like a "who would ever care" kind of bug. Nonetheless technically it seems like it is one. So I thought it best that I report it just the same.

~~~
  class NilClass
    def to_proc
      Proc.new{ |*x| nil }
    end
  end

  def f(&b)
    b.call(1)
  end  

  f(&nil)
  => NoMethodError: undefined method `call' for nil:NilClass
~~~

(Maybe it was fixed already. Filing out this issue reminded me I need to update my version of Ruby.)

---Files--------------------------------
block_from_nil.patch (771 Bytes)


-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2015-03-06 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-10929.20150302234342@ruby-lang.org>
2015-03-02 23:43 ` [ruby-core:68384] [Ruby trunk - Bug #10929] [Open] NilClass#to_proc and & don't mix? transfire
2015-03-06 13:00 ` hanachin [this message]
2015-03-08 22:43 ` [ruby-core:68462] [Ruby trunk - Bug #10929] " ko1
2019-12-16 15:15 ` [ruby-core:96270] [Ruby master Bug#10929] " mame
2020-01-14  2:31 ` [ruby-core:96829] " ko1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-51787.20150306130048.d2b8ae79eb6fabf5@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).