* [ruby-core:72337] Re: [ruby-cvs:60187] nobu:r53034 (trunk): test_io.rb: fix IO#advise on aarch64-linux
@ 2015-12-18 4:13 Joseph Jones
0 siblings, 0 replies; only message in thread
From: Joseph Jones @ 2015-12-18 4:13 UTC (permalink / raw)
To: Ruby developers; +Cc: ruby-core
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Joseph Jones liked your message with Boxer. On December 11, 2015 at 00:48:34 MST, Eric Wong <normalperson@yhbt.net> wrote:nobu@ruby-lang.org wrote:> New Revision: 53034> > http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=53034> > Log:> test_io.rb: fix IO#advise on aarch64-linux> > * test/ruby/test_io.rb (test_advise, test_advise_pipe): fadvise on> aarch64-linux returns ESYS.How about we hide ENOSYS from the user?IO#advise is already a no-op on systems where posix_fadviseis non-existent at build time.--- a/io.c+++ b/io.c@@ -8586,7 +8586,7 @@ do_io_advise(rb_io_t *fptr, VALUE advice, off_t offset, off_t len) ias.len = len; rv = (int)rb_thread_io_blocking_region(io_advise_internal, &ias, fptr->fd);- if (rv) {+ if (rv && rv != ENOSYS) { /* posix_fadvise(2) doesn't set errno. On success it returns 0; otherwise it returns the error code. */ VALUE message = rb_sprintf("%"PRIsVALUE" "
[-- Attachment #2: Type: text/html, Size: 1365 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-18 3:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 4:13 [ruby-core:72337] Re: [ruby-cvs:60187] nobu:r53034 (trunk): test_io.rb: fix IO#advise on aarch64-linux Joseph Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).