From: Joseph Jones <joeyi5216@gmail.com>
To: Ruby developers <ruby-core@ruby-lang.org>
Cc: ruby-core@ruby-lang.org
Subject: [ruby-core:72337] Re: [ruby-cvs:60187] nobu:r53034 (trunk): test_io.rb: fix IO#advise on aarch64-linux
Date: Thu, 17 Dec 2015 21:13:14 -0700 [thread overview]
Message-ID: <E9B7576A-24A7-4C52-AE95-E9B18BC1388D@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Joseph Jones liked your message with Boxer. On December 11, 2015 at 00:48:34 MST, Eric Wong <normalperson@yhbt.net> wrote:nobu@ruby-lang.org wrote:> New Revision: 53034> > http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=53034> > Log:> test_io.rb: fix IO#advise on aarch64-linux> > * test/ruby/test_io.rb (test_advise, test_advise_pipe): fadvise on> aarch64-linux returns ESYS.How about we hide ENOSYS from the user?IO#advise is already a no-op on systems where posix_fadviseis non-existent at build time.--- a/io.c+++ b/io.c@@ -8586,7 +8586,7 @@ do_io_advise(rb_io_t *fptr, VALUE advice, off_t offset, off_t len) ias.len = len; rv = (int)rb_thread_io_blocking_region(io_advise_internal, &ias, fptr->fd);- if (rv) {+ if (rv && rv != ENOSYS) { /* posix_fadvise(2) doesn't set errno. On success it returns 0; otherwise it returns the error code. */ VALUE message = rb_sprintf("%"PRIsVALUE" "
[-- Attachment #2: Type: text/html, Size: 1365 bytes --]
reply other threads:[~2015-12-18 3:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E9B7576A-24A7-4C52-AE95-E9B18BC1388D@gmail.com \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).