Re: ENV["RACK_ENV"] is not set on startup [rack/rack GH-11]

[Matt Todd <chiology@gmail.com>]

I'm not a fan of --env/:env in general, specifically taking issue with
implicitly modifying the middleware stack.

Because of this, I'm actually quite happy with the fact that
ENV['RACK_ENV'] isn't set when --env/:env is set.

I'd much rather this feature go away and let handling environments be
left up to the user.

More specifically:
* --env/:env should default to "development"
* --env/:env should set ENV['RACK_ENV']
* --end/:env should have no other affect
* applications/frameworks should adjust their environments according
to ENV['RACK_ENV'] as they see fit

I'm aware that this is mostly done to ease development and lower the
barrier of entry, which I'm not opposed to doing, but I think there
are other, better ways we can explore such as a separate
feature/option, perhaps only in rackup, that can enable these
middleware.

Thoughts?

Matt



On Thu, Apr 1, 2010 at 3:16 AM, Eric Wong <normalperson@yhbt.net> wrote:
> James Tucker wrote:
>> The possible disparity here is that we use "deployment" and "none"
>> traditionally (with Yehudas Rack::Server deprecating "none" to be
>> implicit instead). I think the best option is to map "production" to
>> "deployment" for the time being, and maybe look at deprecating
>> "deployment" in say, a year, if at all (don't really see why it needs
>> to be removed tbh, other than neatness).
>
> Joshua Peek <josh@joshpeek.com> wrote:
>> +1 I changed Rails to prefer RACK_ENV over RAILS_ENV a while back.
>
> What happens when Rails sees "none" or an empty value?
>
> I've always preferred to start Rack with "none"/empty since I didn't
> like the Rack::CommonLogger defaulting to $stderr which I believe should
> be reserved for more critical messages.  I also prefer Clogger instead
> of CommonLogger for access logs.
>
> With RACK_ENV != RAILS_ENV, it was easy to deploy a Rails app without
> the RACK_ENV=deployment defaults (which I don't want) conflicting
> with the RAILS_ENV=production defaults (which I do want).   I guess
> those apps will have to be reconfigured to use RAILS_ENV=none (or
> RAILS_ENV=something_rack_will_never_understand :)
>
> --
> Eric Wong
>
>
> --
> To unsubscribe, reply using "remove me" as the subject.
>



-- 
Matt Todd
Highgroove Studios
www.highgroove.com
cell: 404-314-2612
blog: maraby.org

Scout - Web Monitoring and Reporting Software
www.scoutapp.com