Re: [GitHub] ENV["RACK_ENV"] is not set on startup [rack/rack GH-11]

[James Tucker <jftucker@gmail.com>]

On 31 Mar 2010, at 14:38, Christian Neukirchen wrote:

> 
>> Subject: [GitHub] ENV["RACK_ENV"] is not set on startup [rack/rack GH-11]
>> 
>> ENV["RACK_ENV"] is not set by rackup on startup, meanwhile at least
>> Passenger, Thin and Unicorn pass this to apps. Besides that Sinatra
>> and Merb use it to set their environment.  You can see the discussion
>> about that in the Unicorn list:
>> http://www.mail-archive.com/mongrel-unicorn@rubyforge.org/msg00123.html
> 
>> The patch to fix it here:
>> http://github.com/tundraghost/rack/commit/90e9dfedf454a1491d97ab1d145cd105fdb1c216
> 
> Discuss.

+1, almost every single framework uses this notion, I think we should have it in the spec.

The possible disparity here is that we use "deployment" and "none" traditionally (with Yehudas Rack::Server deprecating "none" to be implicit instead). I think the best option is to map "production" to "deployment" for the time being, and maybe look at deprecating "deployment" in say, a year, if at all (don't really see why it needs to be removed tbh, other than neatness).

I would argue that an ENV var should be the default unless the argument is explicitly specified, so that patch may be insufficient.

If we get more +1s, I'll import and fixup, as I've been poking Rack::Server recently.

> 
> -- 
> Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org
> 
> 
> -- 
> To unsubscribe, reply using "remove me" as the subject.