From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.128.1 with SMTP id a1cs51165rvd; Wed, 31 Mar 2010 07:12:29 -0700 (PDT) Received-SPF: pass (google.com: domain of 3SlizSwgJCqEKGUVDLFSHNBJM.DPNSBDL-EFWFMHPPHMFHSPVQT.DPN@groups.bounces.google.com designates 10.151.18.3 as permitted sender) client-ip=10.151.18.3; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3SlizSwgJCqEKGUVDLFSHNBJM.DPNSBDL-EFWFMHPPHMFHSPVQT.DPN@groups.bounces.google.com designates 10.151.18.3 as permitted sender) smtp.mail=3SlizSwgJCqEKGUVDLFSHNBJM.DPNSBDL-EFWFMHPPHMFHSPVQT.DPN@groups.bounces.google.com; dkim=pass header.i=3SlizSwgJCqEKGUVDLFSHNBJM.DPNSBDL-EFWFMHPPHMFHSPVQT.DPN@groups.bounces.google.com Received: from mr.google.com ([10.151.18.3]) by 10.151.18.3 with SMTP id v3mr4040805ybi.17.1270044748742 (num_hops = 1); Wed, 31 Mar 2010 07:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:mime-version :subject:from:in-reply-to:date:message-id:references:to:x-mailer :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type:content-transfer-encoding; bh=6TMzBOLVzWLlQxuxNKYt8/yiYOhqVSD/rlJNlhxMBbw=; b=3XUIC8onftrlpesEuIug7krEIFgE7tovf95jNoIiHJh5vC6mUetMgTqMMnvLCYdx0b 5frTH/JhBQKhpaHzdW1TN6zraZhwwOz4RmO6MdSmxf7ijFLAg7bsO4lAGEx2TjAC1XxG Jb+mebnC7rJIgfTruaX4l7iCDkiVFqh+3gA/g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:subject:from:in-reply-to:date :message-id:references:to:x-mailer:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; b=IuPL+qmKX8tSUdnduAjC5Htg5gCmptVbMF9+zsv+yl0+/gr4gesx1G/8pmw5yKKlBJ MirgGUAqKYjFaEABYIM8qyl1vAqUB2fOgylAE33xmpxdLKUOxGunFhkrzLyJlGVNZ6FU BrGqt12D6W6Re+fURQaJbvb6uJ8MOnSW0C69c= Received: by 10.151.18.3 with SMTP id v3mr398789ybi.17.1270044746717; Wed, 31 Mar 2010 07:12:26 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.91.50.27 with SMTP id c27ls119655agk.5.p; Wed, 31 Mar 2010 07:12:25 -0700 (PDT) Received: by 10.91.58.18 with SMTP id l18mr254014agk.1.1270044740076; Wed, 31 Mar 2010 07:12:20 -0700 (PDT) Received: by 10.91.58.18 with SMTP id l18mr253979agk.1.1270044737964; Wed, 31 Mar 2010 07:12:17 -0700 (PDT) Return-Path: Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by gmr-mx.google.com with ESMTP id 19si11865yxe.15.2010.03.31.07.12.16; Wed, 31 Mar 2010 07:12:16 -0700 (PDT) Received-SPF: pass (google.com: domain of jftucker@gmail.com designates 74.125.78.27 as permitted sender) client-ip=74.125.78.27; Received: by ey-out-2122.google.com with SMTP id d26so9916eyd.13 for ; Wed, 31 Mar 2010 07:12:16 -0700 (PDT) Received: by 10.213.81.204 with SMTP id y12mr2268234ebk.47.1270044735315; Wed, 31 Mar 2010 07:12:15 -0700 (PDT) Return-Path: Received: from [192.168.1.105] (bb-87-81-237-21.ukonline.co.uk [87.81.237.21]) by mx.google.com with ESMTPS id 14sm3739805ewy.10.2010.03.31.07.12.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 31 Mar 2010 07:12:14 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1078) Subject: Re: [GitHub] ENV["RACK_ENV"] is not set on startup [rack/rack GH-11] From: James Tucker In-Reply-To: <87hbnwr4pu.fsf@gmail.com> Date: Wed, 31 Mar 2010 15:12:13 +0100 Message-Id: <920480E1-F9EE-4B06-98A4-77784BF66CCF@gmail.com> References: <87hbnwr4pu.fsf@gmail.com> To: rack-devel@googlegroups.com X-Mailer: Apple Mail (2.1078) X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jftucker@gmail.com designates 74.125.78.27 as permitted sender) smtp.mail=jftucker@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: jftucker@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/838c8abdaae55bb8 X-Message-Url: http://groups.google.com/group/rack-devel/msg/a14fed0020354a3 Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable On 31 Mar 2010, at 14:38, Christian Neukirchen wrote: >=20 >> Subject: [GitHub] ENV["RACK_ENV"] is not set on startup [rack/rack = GH-11] >>=20 >> ENV["RACK_ENV"] is not set by rackup on startup, meanwhile at least >> Passenger, Thin and Unicorn pass this to apps. Besides that Sinatra >> and Merb use it to set their environment. You can see the discussion >> about that in the Unicorn list: >> = http://www.mail-archive.com/mongrel-unicorn@rubyforge.org/msg00123.html >=20 >> The patch to fix it here: >> = http://github.com/tundraghost/rack/commit/90e9dfedf454a1491d97ab1d145cd105= fdb1c216 >=20 > Discuss. +1, almost every single framework uses this notion, I think we should = have it in the spec. The possible disparity here is that we use "deployment" and "none" = traditionally (with Yehudas Rack::Server deprecating "none" to be = implicit instead). I think the best option is to map "production" to = "deployment" for the time being, and maybe look at deprecating = "deployment" in say, a year, if at all (don't really see why it needs to = be removed tbh, other than neatness). I would argue that an ENV var should be the default unless the argument = is explicitly specified, so that patch may be insufficient. If we get more +1s, I'll import and fixup, as I've been poking = Rack::Server recently. >=20 > --=20 > Christian Neukirchen = http://chneukirchen.org >=20 >=20 > --=20 > To unsubscribe, reply using "remove me" as the subject.