From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.128.1 with SMTP id a1cs98512rvd; Thu, 1 Apr 2010 01:21:29 -0700 (PDT) Received-SPF: pass (google.com: domain of 3hle0SwgJCt0BGHNKNFXFL9HK.BNLQ9BJ-CDUDKFNNFKDFQNTOR.BNL@groups.bounces.google.com designates 10.91.160.33 as permitted sender) client-ip=10.91.160.33; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3hle0SwgJCt0BGHNKNFXFL9HK.BNLQ9BJ-CDUDKFNNFKDFQNTOR.BNL@groups.bounces.google.com designates 10.91.160.33 as permitted sender) smtp.mail=3hle0SwgJCt0BGHNKNFXFL9HK.BNLQ9BJ-CDUDKFNNFKDFQNTOR.BNL@groups.bounces.google.com; dkim=pass header.i=3hle0SwgJCt0BGHNKNFXFL9HK.BNLQ9BJ-CDUDKFNNFKDFQNTOR.BNL@groups.bounces.google.com Received: from mr.google.com ([10.91.160.33]) by 10.91.160.33 with SMTP id m33mr1164438ago.54.1270110088278 (num_hops = 1); Thu, 01 Apr 2010 01:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:in-reply-to :references:from:date:received:message-id:subject:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type:content-transfer-encoding; bh=0S/VHVBbAHvgE4M4AXGIf7BYxbVMjrZ7VjGcoTlK8j8=; b=I2vOTfPmoTSPmoZ7SeEokKfYgq3ApfqYOEP3S1o8VeZc+SobJxomJGHVyhoFjtPTNs 8VCLl+Wngj71m+HaS0wab16L+zalqoZR31eZ5miN4c5k8VPHKKwVKU08jXsqINFmqZO4 ckr68FmJN5zvNz46DxMgzEhoa9eQBXNemb0sc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:in-reply-to:references:from :date:message-id:subject:to:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; b=Cxp9/wZc6D2UlpEOz62Uddgx9XUB2bqrzezw2RIKtPACsxZFL4p8M/tSHcuYefwtQ2 8VfzNhtLt1G2ZQbyqudII0al+UNNjCI6HAFbwxui7SI/rnjSFKiesB5FG9J8LXG2UxMI /Y67r4/9CnoCqc7nl/E8dqH20QeuhkkjDbMbU= Received: by 10.91.160.33 with SMTP id m33mr132023ago.54.1270110086859; Thu, 01 Apr 2010 01:21:26 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.204.35.68 with SMTP id o4ls659038bkd.1.p; Thu, 01 Apr 2010 01:21:24 -0700 (PDT) Received: by 10.204.38.84 with SMTP id a20mr38230bke.23.1270110084559; Thu, 01 Apr 2010 01:21:24 -0700 (PDT) Received: by 10.204.38.84 with SMTP id a20mr38229bke.23.1270110084497; Thu, 01 Apr 2010 01:21:24 -0700 (PDT) Return-Path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gmr-mx.google.com with ESMTP id v26si7816889bkt.3.2010.04.01.01.21.23; Thu, 01 Apr 2010 01:21:23 -0700 (PDT) Received-SPF: pass (google.com: domain of chiology@gmail.com designates 74.125.82.43 as permitted sender) client-ip=74.125.82.43; Received: by wwf26 with SMTP id 26so578444wwf.30 for ; Thu, 01 Apr 2010 01:21:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.29.16 with HTTP; Thu, 1 Apr 2010 01:21:03 -0700 (PDT) In-Reply-To: <20100401071650.GB30070@dcvr.yhbt.net> References: <87hbnwr4pu.fsf@gmail.com> <20100401071650.GB30070@dcvr.yhbt.net> From: Matt Todd Date: Thu, 1 Apr 2010 04:21:03 -0400 Received: by 10.216.88.148 with SMTP id a20mr240911wef.124.1270110083156; Thu, 01 Apr 2010 01:21:23 -0700 (PDT) Message-ID: Subject: Re: ENV["RACK_ENV"] is not set on startup [rack/rack GH-11] To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of chiology@gmail.com designates 74.125.82.43 as permitted sender) smtp.mail=chiology@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: chiology@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/838c8abdaae55bb8 X-Message-Url: http://groups.google.com/group/rack-devel/msg/6b9436a7b8b8429c Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I'm not a fan of --env/:env in general, specifically taking issue with implicitly modifying the middleware stack. Because of this, I'm actually quite happy with the fact that ENV['RACK_ENV'] isn't set when --env/:env is set. I'd much rather this feature go away and let handling environments be left up to the user. More specifically: * --env/:env should default to "development" * --env/:env should set ENV['RACK_ENV'] * --end/:env should have no other affect * applications/frameworks should adjust their environments according to ENV['RACK_ENV'] as they see fit I'm aware that this is mostly done to ease development and lower the barrier of entry, which I'm not opposed to doing, but I think there are other, better ways we can explore such as a separate feature/option, perhaps only in rackup, that can enable these middleware. Thoughts? Matt On Thu, Apr 1, 2010 at 3:16 AM, Eric Wong wrote: > James Tucker wrote: >> The possible disparity here is that we use "deployment" and "none" >> traditionally (with Yehudas Rack::Server deprecating "none" to be >> implicit instead). I think the best option is to map "production" to >> "deployment" for the time being, and maybe look at deprecating >> "deployment" in say, a year, if at all (don't really see why it needs >> to be removed tbh, other than neatness). > > Joshua Peek wrote: >> +1 I changed Rails to prefer RACK_ENV over RAILS_ENV a while back. > > What happens when Rails sees "none" or an empty value? > > I've always preferred to start Rack with "none"/empty since I didn't > like the Rack::CommonLogger defaulting to $stderr which I believe should > be reserved for more critical messages. =C2=A0I also prefer Clogger inste= ad > of CommonLogger for access logs. > > With RACK_ENV !=3D RAILS_ENV, it was easy to deploy a Rails app without > the RACK_ENV=3Ddeployment defaults (which I don't want) conflicting > with the RAILS_ENV=3Dproduction defaults (which I do want). =C2=A0 I gues= s > those apps will have to be reconfigured to use RAILS_ENV=3Dnone (or > RAILS_ENV=3Dsomething_rack_will_never_understand :) > > -- > Eric Wong > > > -- > To unsubscribe, reply using "remove me" as the subject. > --=20 Matt Todd Highgroove Studios www.highgroove.com cell: 404-314-2612 blog: maraby.org Scout - Web Monitoring and Reporting Software www.scoutapp.com