From: Jeremy Kemper <jeremy@bitsweat.net>
To: rack-devel@googlegroups.com
Subject: Re: Rack::ConditionalGet should check for ETag header, not Etag
Date: Thu, 4 Mar 2010 12:25:19 -0800 [thread overview]
Message-ID: <69a2885c1003041225i2acc95dcoc5f17fc041c673f8@mail.gmail.com> (raw)
In-Reply-To: <69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com>
On Thu, Mar 4, 2010 at 12:13 PM, Jeremy Kemper <jeremy@bitsweat.net> wrote:
> For your consideration: a bug fix for Rack::ConditionalGet.
>
> The middleware checks for headers['Etag'] when it should be checking for 'ETag'.
>
> The bug is masked by the specs which use a case-indifferent
> HeaderHash. Fixed and added a spec that returns a headers Hash.
This is wrong. I glossed over the explicit use of HeadersHash in the
middleware, and it was masked by an error in the failing spec I'd just
written.
Nevertheless, it's a good idea to use the correct header name, so the
patch stands.
jeremy
prev parent reply other threads:[~2010-03-04 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 20:13 Rack::ConditionalGet should check for ETag header, not Etag Jeremy Kemper
2010-03-04 20:25 ` Jeremy Kemper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a2885c1003041225i2acc95dcoc5f17fc041c673f8@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).