From: Jeremy Kemper <jeremy@bitsweat.net>
To: rack-devel@googlegroups.com
Subject: Rack::ConditionalGet should check for ETag header, not Etag
Date: Thu, 4 Mar 2010 12:13:15 -0800 [thread overview]
Message-ID: <69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com> (raw)
For your consideration: a bug fix for Rack::ConditionalGet.
The middleware checks for headers['Etag'] when it should be checking for 'ETag'.
The bug is masked by the specs which use a case-indifferent
HeaderHash. Fixed and added a spec that returns a headers Hash.
http://github.com/jeremy/rack/commit/e59456ade9f7d4e82742913bbcad927ca5e28859
jeremy
next reply other threads:[~2010-03-04 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 20:13 Jeremy Kemper [this message]
2010-03-04 20:25 ` Rack::ConditionalGet should check for ETag header, not Etag Jeremy Kemper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).