From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.140.3 with SMTP id n3cs224514rvd; Thu, 4 Mar 2010 12:25:23 -0800 (PST) Received-SPF: pass (google.com: domain of 3MReQSwYMCiQJEREMYBITSWEAT.NETRACK-DEVELGOOGLEGROUPS.COM@groups.bounces.google.com designates 10.224.43.194 as permitted sender) client-ip=10.224.43.194; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3MReQSwYMCiQJEREMYBITSWEAT.NETRACK-DEVELGOOGLEGROUPS.COM@groups.bounces.google.com designates 10.224.43.194 as permitted sender) smtp.mail=3MReQSwYMCiQJEREMYBITSWEAT.NETRACK-DEVELGOOGLEGROUPS.COM@groups.bounces.google.com; dkim=pass header.i=3MReQSwYMCiQJEREMYBITSWEAT.NETRACK-DEVELGOOGLEGROUPS.COM@groups.bounces.google.com Received: from mr.google.com ([10.224.43.194]) by 10.224.43.194 with SMTP id x2mr3016630qae.10.1267734322882 (num_hops = 1); Thu, 04 Mar 2010 12:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:in-reply-to :references:date:message-id:subject:from:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type; bh=3+yOi8nxcS1UZk0pUB04Rn/Lsxe/YPt/OTfZrfLw06c=; b=GNworyOHLCAGrCvtFIVMK00vj33YQJJvtKm1+RBXOAUWhcC7AvVmt9SJ5eAtiWBAH5 FYRPQwpnGG4qzFGSsIrxIcY7/JfRSs2z9mPge/DcvVZYs0rm6Y/ExzwUZLeXhGRXuiU6 q04K7KOCgedLfr8PjBUxkkAR4VVui4sK/WS4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:in-reply-to:references:date :message-id:subject:from:to:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type; b=BCyu7U6C3DM42bnt6YdFtl3SbUP7TGul7WW2UBU5fdUl16nC8fnnmBZQg0OxqttlbF BcbecLio4RyusI1oZoEY0N0blDLbV92QiDx0DDq6/lOX/87AfaMhm6/Yu5uSX7oWGbwE Q15yq4Ef8zvmm3qnyy5g0pH53l9NQP0T+INQA= Received: by 10.224.43.194 with SMTP id x2mr322609qae.10.1267734321614; Thu, 04 Mar 2010 12:25:21 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.224.22.138 with SMTP id n10ls1122397qab.0.p; Thu, 04 Mar 2010 12:25:19 -0800 (PST) Received: by 10.224.65.69 with SMTP id h5mr978443qai.2.1267734319628; Thu, 04 Mar 2010 12:25:19 -0800 (PST) Received: by 10.224.65.69 with SMTP id h5mr978441qai.2.1267734319600; Thu, 04 Mar 2010 12:25:19 -0800 (PST) Return-Path: Received: from qw-out-1920.google.com (qw-out-1920.google.com [74.125.92.145]) by gmr-mx.google.com with ESMTP id 25si74820qyk.15.2010.03.04.12.25.19; Thu, 04 Mar 2010 12:25:19 -0800 (PST) Received-SPF: neutral (google.com: 74.125.92.145 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) client-ip=74.125.92.145; Received: by qw-out-1920.google.com with SMTP id 14so642609qwa.8 for ; Thu, 04 Mar 2010 12:25:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.220.139 with SMTP id hy11mr937870qcb.8.1267734319285; Thu, 04 Mar 2010 12:25:19 -0800 (PST) In-Reply-To: <69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com> References: <69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com> Date: Thu, 4 Mar 2010 12:25:19 -0800 Message-ID: <69a2885c1003041225i2acc95dcoc5f17fc041c673f8@mail.gmail.com> Subject: Re: Rack::ConditionalGet should check for ETag header, not Etag From: Jeremy Kemper To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 74.125.92.145 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) smtp.mail=jeremy@bitsweat.net X-Original-Sender: jeremy@bitsweat.net Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/33d5b0eaea2038f X-Message-Url: http://groups.google.com/group/rack-devel/msg/cff258469bb1d81 Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 On Thu, Mar 4, 2010 at 12:13 PM, Jeremy Kemper wrote: > For your consideration: a bug fix for Rack::ConditionalGet. > > The middleware checks for headers['Etag'] when it should be checking for 'ETag'. > > The bug is masked by the specs which use a case-indifferent > HeaderHash. Fixed and added a spec that returns a headers Hash. This is wrong. I glossed over the explicit use of HeadersHash in the middleware, and it was masked by an error in the failing spec I'd just written. Nevertheless, it's a good idea to use the correct header name, so the patch stands. jeremy