3 files changed, 28 insertions, 30 deletions

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 48ab7fc2..ff6d8958 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -331,20 +331,20 @@ sub cmd_newnews ($$$$;$$) {
         };
         return '.' unless @srch;
 
-        my $opts = { limit => 1000, offset => 0 };
+        my $prev = 0;
         long_response($self, 0, long_response_limit, sub {
                 my ($i) = @_;
                 my $srch = $srch[0];
-                my $msgs = $srch->query_ts($ts, $opts);
-                if (my $nr = scalar @$msgs) {
+                my $msgs = $srch->query_ts($ts, $prev);
+                if (scalar @$msgs) {
                         more($self, '<' .
                                 join(">\r\n<", map { $_->mid } @$msgs ).
                                 '>');
-                        $opts->{offset} += $nr;
+                        $prev = $msgs->[-1]->{num};
                 } else {
                         shift @srch;
                         if (@srch) { # continue onto next newsgroup
-                                $opts->{offset} = 0;
+                                $prev = 0;
                         } else { # break out of the long response.
                                 $$i = long_response_limit;
                         }
@@ -582,7 +582,7 @@ sub long_response ($$$$) {
         $self->{long_res} = sub {
                 # limit our own running time for fairness with other
                 # clients and to avoid buffering too much:
-                my $lim = 100;
+                my $lim = $end == long_response_limit ? 1 : 100;
 
                 my $err;
                 do {
@@ -710,20 +710,19 @@ sub hdr_searchmsg ($$$$) {
                 return $r unless ref $r;
                 my ($beg, $end) = @$r;
                 more($self, $xhdr ? r221 : r225);
-                my $off = 0;
-                long_response($self, $beg, $end, sub {
+                my $cur = $beg;
+                long_response($self, 0, long_response_limit, sub {
                         my ($i) = @_;
-                        my $msgs = $srch->query_xover($beg, $end, $off);
-                        my $nr = scalar @$msgs or return;
-                        $off += $nr;
+                        my $msgs = $srch->query_xover($cur, $end);
+                        my $nr = scalar @$msgs or
+                                        return ($$i = long_response_limit);
                         my $tmp = '';
                         foreach my $s (@$msgs) {
                                 $tmp .= $s->num . ' ' . $s->$field . "\r\n";
                         }
                         utf8::encode($tmp);
                         do_more($self, $tmp);
-                        # -1 to adjust for implicit increment in long_response
-                        $$i = $nr ? $$i + $nr - 1 : long_response_limit;
+                        $cur = $msgs->[-1]->{num} + 1;
                 });
         }
 }
@@ -848,20 +847,18 @@ sub cmd_xover ($;$) {
         my ($beg, $end) = @$r;
         more($self, "224 Overview information follows for $beg to $end");
         my $srch = $self->{ng}->search;
-        my $off = 0;
-        long_response($self, $beg, $end, sub {
+        my $cur = $beg;
+        long_response($self, 0, long_response_limit, sub {
                 my ($i) = @_;
-                my $msgs = $srch->query_xover($beg, $end, $off);
-                my $nr = scalar @$msgs or return;
-                $off += $nr;
+                my $msgs = $srch->query_xover($cur, $end);
+                my $nr = scalar @$msgs or return ($$i = long_response_limit);
 
                 # OVERVIEW.FMT
                 more($self, join("\r\n", map {
                         over_line($_->{num}, $_);
                         } @$msgs));
-
-                # -1 to adjust for implicit increment in long_response
-                $$i = $nr ? $$i + $nr - 1 : long_response_limit;
+                $cur = $msgs->[-1]->{num} + 1;
+                1;
         });
 }
 
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 3d285ac2..a7fd1315 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -51,25 +51,26 @@ sub do_get {
         my $dbh = $self->connect;
         my $lim = (($opts->{limit} || 0) + 0) || 1000;
         my $off = (($opts->{offset} || 0) + 0) || 0;
-        $sql .= "LIMIT $lim OFFSET $off";
+        $sql .= "LIMIT $lim";
+        $sql .= " OFFSET $off" if $off > 0;
         my $msgs = $dbh->selectall_arrayref($sql, { Slice => {} }, @args);
         load_from_row($_) for @$msgs;
         $msgs
 }
 
 sub query_xover {
-        my ($self, $beg, $end, $off) = @_;
-        do_get($self, <<'', { offset => $off }, $beg, $end);
+        my ($self, $beg, $end) = @_;
+        do_get($self, <<'', {}, $beg, $end);
 SELECT * FROM over WHERE num >= ? AND num <= ?
 ORDER BY num ASC
 
 }
 
 sub query_ts {
-        my ($self, $ts, $opts) = @_;
-        do_get($self, <<'', $opts, $ts);
-SELECT * FROM over WHERE num > 0 AND ts >= ?
-ORDER BY ts ASC
+        my ($self, $ts, $prev) = @_;
+        do_get($self, <<'', {}, $ts, $prev);
+SELECT num,ddd FROM over WHERE ts >= ? AND num > ?
+ORDER BY num ASC
 
 }
 
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 84c0a22f..f7fdf854 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -291,8 +291,8 @@ sub query_xover {
 }
 
 sub query_ts {
-        my ($self, $ts, $offset) = @_;
-        $self->{over_ro}->query_ts($ts, $offset);
+        my ($self, $ts, $prev) = @_;
+        $self->{over_ro}->query_ts($ts, $prev);
 }
 
 sub first_smsg_by_mid {