about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/Gcf2.pm2
-rw-r--r--lib/PublicInbox/Inbox.pm9
2 files changed, 4 insertions, 7 deletions
diff --git a/lib/PublicInbox/Gcf2.pm b/lib/PublicInbox/Gcf2.pm
index 041dffe7..fe6afef2 100644
--- a/lib/PublicInbox/Gcf2.pm
+++ b/lib/PublicInbox/Gcf2.pm
@@ -35,7 +35,7 @@ BEGIN {
                 if (open(my $fh, '<', $f)) {
                         chomp($l, $c);
                         local $/;
-                        $c_src = <$fh>;
+                        defined($c_src = <$fh>) or die "read $f: $!\n";
                         $CFG{LIBS} = $l;
                         $CFG{CCFLAGSEX} = $c;
                         last;
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 1b9b56ff..af6380a7 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -210,12 +210,9 @@ sub over {
 
 sub try_cat {
         my ($path) = @_;
-        my $rv = '';
-        if (open(my $fh, '<', $path)) {
-                local $/;
-                $rv = <$fh>;
-        }
-        $rv;
+        open(my $fh, '<', $path) or return '';
+        local $/;
+        <$fh> // '';
 }
 
 sub cat_desc ($) {