diff options
author | Eric Wong <e@yhbt.net> | 2020-08-10 02:11:58 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-08-10 05:56:07 +0000 |
commit | 67380a130f18b5b3abbee82346ff7c15185f41e8 (patch) | |
tree | 98c68c6cc8d6d9aec7fd5216f48e70af93303bd7 /t | |
parent | 6f9a86728b98887ae0d76234afb2679b6f6dd4ae (diff) | |
download | public-inbox-67380a130f18b5b3abbee82346ff7c15185f41e8.tar.gz |
We can use open(..., undef) natively in Perl in t/import.t In places where we need a pathname, the File::Temp OO API gives us auto-unlinking for free.
Diffstat (limited to 't')
-rw-r--r-- | t/import.t | 5 |
1 files changed, 2 insertions, 3 deletions
@@ -9,7 +9,6 @@ use PublicInbox::Git; use PublicInbox::Import; use PublicInbox::Spawn qw(spawn); use Fcntl qw(:DEFAULT SEEK_SET); -use File::Temp qw/tempfile/; use PublicInbox::TestCommon; use MIME::Base64 3.05; # Perl 5.10.0 / 5.9.2 my ($dir, $for_destroy) = tmpdir(); @@ -37,11 +36,11 @@ if ($v2) { is($mime->as_string, $$raw_email, 'string matches'); is($smsg->{raw_bytes}, length($$raw_email), 'length matches'); my @cmd = ('git', "--git-dir=$git->{git_dir}", qw(hash-object --stdin)); - my $in = tempfile(); + open my $in, '+<', undef or BAIL_OUT "open(+<): $!"; print $in $mime->as_string or die "write failed: $!"; $in->flush or die "flush failed: $!"; seek($in, 0, SEEK_SET); - my $out = tempfile(); + open my $out, '+<', undef or BAIL_OUT "open(+<): $!"; my $pid = spawn(\@cmd, {}, { 0 => $in, 1 => $out }); is(waitpid($pid, 0), $pid, 'waitpid succeeds on hash-object'); is($?, 0, 'hash-object'); |