about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-07-05 23:27:17 +0000
committerEric Wong <e@yhbt.net>2020-07-06 20:01:15 +0000
commitcfd960f6a2c1cff9a9537b0758fcde1d3203b17f (patch)
tree0533789b92dfb3ccaaf874bb77db3fbdb5596db0 /lib
parent2c6e8b10e3f9f3b047009126426ce634c8f29a23 (diff)
downloadpublic-inbox-cfd960f6a2c1cff9a9537b0758fcde1d3203b17f.tar.gz
We currently don't use bytes::length in ->write, so there's no
need to `use bytes'.  Favor `//=' to describe the intent of the
conditional assignment since the C::R::Z::Deflate object is
always truthy.  Also use the local $gz variable to avoid
unnecessary {gz} hash lookups.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/GzipFilter.pm7
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm
index 86409586..a7355a8d 100644
--- a/lib/PublicInbox/GzipFilter.pm
+++ b/lib/PublicInbox/GzipFilter.pm
@@ -4,7 +4,6 @@
 # Qspawn filter
 package PublicInbox::GzipFilter;
 use strict;
-use bytes (); # length
 use Compress::Raw::Zlib qw(Z_FINISH Z_OK);
 my %OPT = (-WindowBits => 15 + 16, -AppendOutput => 1);
 
@@ -24,21 +23,21 @@ sub translate ($$) {
         # allocate the zlib context lazily here, instead of in ->new.
         # Deflate contexts are memory-intensive and this object may
         # be sitting in the Qspawn limiter queue for a while.
-        my $gz = $self->{gz} ||= do {
+        my $gz = $self->{gz} //= do {
                 my ($g, $err) = Compress::Raw::Zlib::Deflate->new(%OPT);
                 $err == Z_OK or die "Deflate->new failed: $err";
                 $g;
         };
         my $zbuf = delete($self->{zbuf});
         if (defined $_[1]) { # my $buf = $_[1];
-                my $err = $self->{gz}->deflate($_[1], $zbuf);
+                my $err = $gz->deflate($_[1], $zbuf);
                 die "gzip->deflate: $err" if $err != Z_OK;
                 return $zbuf if length($zbuf) >= 8192;
 
                 $self->{zbuf} = $zbuf;
                 '';
         } else { # undef == EOF
-                my $err = $self->{gz}->flush($zbuf, Z_FINISH);
+                my $err = $gz->flush($zbuf, Z_FINISH);
                 die "gzip->flush: $err" if $err != Z_OK;
                 $zbuf;
         }