diff options
author | Eric Wong <e@80x24.org> | 2021-09-09 05:24:59 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2021-09-09 05:42:55 +0000 |
commit | be9e047b80f1a91492efcf92bb449d789b20edf5 (patch) | |
tree | f85bf7c316e0b7304334f65f189fabf521f6ff64 /lib | |
parent | fb4b16193d0d839a0869b2cf2295b7384ef5f1e3 (diff) | |
download | public-inbox-be9e047b80f1a91492efcf92bb449d789b20edf5.tar.gz |
Since we always enable SO_KEEPALIVE unconditionally, having it in {mic_arg} leads to unnecessary IPC overhead and memory use.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/PublicInbox/NetReader.pm | 3 | ||||
-rw-r--r-- | lib/PublicInbox/Watch.pm | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index b5d14f13..9faa362c 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -51,7 +51,7 @@ sub mic_new ($$$$) { $socks{Socket} = IO::Socket::Socks->new(%opt) or die "E: <$$uri> ".eval('$IO::Socket::Socks::SOCKS_ERROR'); } - PublicInbox::IMAPClient->new(%$mic_arg, %socks); + PublicInbox::IMAPClient->new(%$mic_arg, %socks, Keepalive => 1); } sub auth_anon_cb { '' }; # for Mail::IMAPClient::Authcallback @@ -76,7 +76,6 @@ sub mic_for ($$$$) { # mic = Mail::IMAPClient Port => $uri->port, Server => $host, Ssl => $uri->scheme eq 'imaps', - Keepalive => 1, # SO_KEEPALIVE %$common, # may set Starttls, Compress, Debug .... }; $mic_arg->{Ssl} = 1 if $uri->scheme eq 'imaps'; diff --git a/lib/PublicInbox/Watch.pm b/lib/PublicInbox/Watch.pm index 482d35c4..7a35ee59 100644 --- a/lib/PublicInbox/Watch.pm +++ b/lib/PublicInbox/Watch.pm @@ -358,7 +358,7 @@ sub watch_imap_idle_1 ($$$) { my $mic; local $0 = $uri->mailbox." $sec"; until ($self->{quit}) { - $mic //= PublicInbox::IMAPClient->new(%$mic_arg); + $mic //= PublicInbox::IMAPClient->new(%$mic_arg,Keepalive => 1); my $err; if ($mic && $mic->IsConnected) { local $self->{mics_cached}->{$sec} = $mic; |