diff options
| author | Eric Wong <e@80x24.org> | 2023-11-28 14:56:17 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2023-11-29 02:13:19 +0000 |
| commit | a1ff0b13f09e2a959de692e3f29ab52502a76abd (patch) | |
| tree | fbfc15fc9a121e15f5906efdb803119b3dd1d102 /lib | |
| parent | f1e472e1851b708750c7ac0927792fb38e22b8e9 (diff) | |
| download | public-inbox-a1ff0b13f09e2a959de692e3f29ab52502a76abd.tar.gz | |
solver: schedule cleanup after synchronous git->check
We don't want hundreds of git cat-file processes for coderepos lingering around.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/PublicInbox/Git.pm | 7 | ||||
| -rw-r--r-- | lib/PublicInbox/SolverGit.pm | 3 |
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index fe834210..7c6e15b7 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -628,10 +628,15 @@ sub event_step { } } +sub schedule_cleanup { + my ($self) = @_; + PublicInbox::DS::add_uniq_timer($self+0, 30, \&cleanup, $self, 1); +} + # idempotently registers with DS epoll/kqueue/select/poll sub watch_async ($) { my ($self) = @_; - PublicInbox::DS::add_uniq_timer($self+0, 30, \&cleanup, $self, 1); + schedule_cleanup($self); $self->{epwatch} //= do { $self->SUPER::new($self->{sock}, EPOLLIN); \undef; diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index ba3c94cb..7cc10198 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -82,7 +82,10 @@ sub solve_existing ($$) { my $try = $want->{try_gits} //= [ @{$self->{gits}} ]; # array copy my $git = shift @$try or die 'BUG {try_gits} empty'; my $oid_b = $want->{oid_b}; + + # can't use async_check due to last_check_err :< my ($oid_full, $type, $size) = $git->check($oid_b); + $git->schedule_cleanup if $self->{psgi_env}->{'pi-httpd.async'}; if ($oid_b eq ($oid_full // '') || (defined($type) && (!$self->{have_hints} || $type eq 'blob'))) { |