diff options
| author | Eric Wong <e@80x24.org> | 2022-08-04 08:16:58 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2022-08-04 20:09:33 +0000 |
| commit | 674b0268c057d852342347264b374ef0cd130e51 (patch) | |
| tree | 3e828bd8659080e450fefa8e797d414558b40e02 /lib | |
| parent | e28e9985f8b93ba5b0009f66be3b214f5fdea9b5 (diff) | |
| download | public-inbox-674b0268c057d852342347264b374ef0cd130e51.tar.gz | |
There's no need to create two intermediate arrays when we can modify the existing arrayref.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/PublicInbox/Over.pm | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index 786f9d92..d6409b2a 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -273,13 +273,13 @@ SELECT ibx_id,xnum,oidbin FROM xref3 WHERE docid = ? ORDER BY ibx_id,xnum ASC my $eidx_key_sth = $dbh->prepare_cached(<<'', undef, 1); SELECT eidx_key FROM inboxes WHERE ibx_id = ? - [ map { - my $r = $_; + for my $r (@$rows) { $eidx_key_sth->execute($r->[0]); my $eidx_key = $eidx_key_sth->fetchrow_array; $eidx_key //= "missing://ibx_id=$r->[0]"; - "$eidx_key:$r->[1]:".unpack('H*', $r->[2]); - } @$rows ]; + $r = "$eidx_key:$r->[1]:".unpack('H*', $r->[2]); + } + $rows; } sub next_by_mid { |