diff options
| author | Eric Wong <e@80x24.org> | 2022-07-22 20:18:09 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2022-07-28 08:11:59 +0000 |
| commit | 4eee5af6011cc8cdefb66c9729952c7eff5c0b0b (patch) | |
| tree | 461b6ebe1424fffed0c450d98602532c60350b19 /lib | |
| parent | d0bc58517c97c8982fdf42533297d96be9efb484 (diff) | |
| download | public-inbox-4eee5af6011cc8cdefb66c9729952c7eff5c0b0b.tar.gz | |
Apparently, --subject doesn't work[1] with "git send-email" in
this context. So drop the CLI arg and add a note to tell the
user to set a "Subject:" line in their response body, instead.
[1] I'm not sure if --subject ever worked as I thought it would,
or if it's a regression. In either case, there are current
versions of git where it doesn't, so just tell users to use
the currently supported method.
Link: https://80x24.org/lore/git/CAC4O8c-Tf11CpwuRudyrpXv5bGshuyEenV9kKrs0zRWER-+yHA@mail.gmail.com/
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/PublicInbox/Reply.pm | 3 | ||||
| -rw-r--r-- | lib/PublicInbox/View.pm | 3 |
2 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/Reply.pm b/lib/PublicInbox/Reply.pm index 592dfb62..091f20bc 100644 --- a/lib/PublicInbox/Reply.pm +++ b/lib/PublicInbox/Reply.pm @@ -68,7 +68,6 @@ sub mailto_arg_link { my $obfs = $ibx->{obfuscate}; my $subj = $hdr->header('Subject') || ''; $subj = "Re: $subj" unless $subj =~ /\bRe:/i; - my $subj_raw = $subj; my $mid = $hdr->header_raw('Message-ID'); push @arg, '--in-reply-to='.squote_maybe(mid_clean($mid)); my $irt = mid_href($mid); @@ -98,8 +97,6 @@ sub mailto_arg_link { } } - push @arg, "--subject=".squote_maybe($subj_raw); - # I'm not sure if address obfuscation and mailto: links can # be made compatible; and address obfuscation is misguided, # anyways. diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index b90cb08b..fa96cca3 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -142,6 +142,9 @@ $info <a href="$se_url">$se_url</a> $link</pre> + + Be sure your reply has a <b>Subject:</b> header at the top and a blank line + before the message body. EOF } |