about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-06-15 09:17:28 +0000
committerEric Wong <e@yhbt.net>2020-06-16 00:07:06 +0000
commit46595636f006ec8817b5626168c25310f4a67d43 (patch)
tree4777977dd98be53ebe06e1168acb3b3eda9ac1cf /lib
parent01f2e00be4671e1100b6180310c0fd8c0035ebc8 (diff)
downloadpublic-inbox-46595636f006ec8817b5626168c25310f4a67d43.tar.gz
stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects.  This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/IMAP.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
 }
 
 sub stop_idle ($$) {
-        my ($self, $ibx);
+        my ($self, $ibx) = @_;
         my $sock = $self->{sock} or return;
         my $fd = fileno($sock);
         delete $IDLERS->{$fd};