about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-03-19 10:35:57 -0200
committerEric Wong <e@80x24.org>2021-03-19 12:46:56 +0000
commit1d1498c6c5d42733bd63bd109076882c5d6e8a2a (patch)
tree9230950701e6983b118a2a94d82b5ee51c5b4d7f /lib
parentf7af186cf033daae8947f3368378e07ee116bb9c (diff)
downloadpublic-inbox-1d1498c6c5d42733bd63bd109076882c5d6e8a2a.tar.gz
git 2.11 and earlier could not handle git directories with
newlines in them, nor does libgit2 support them.

Followup-to: d87dd0e679587043 ("config: reject `\n' in `inboxdir'")
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/Config.pm4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 228de4ff..26ac298e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -510,6 +510,10 @@ sub _fill_ei ($$) {
         my $pfx = "extindex.$name";
         my $d = $self->{"$pfx.topdir"} // return;
         -d $d or return;
+        if (index($d, "\n") >= 0) {
+                warn "E: `$d' must not contain `\\n'\n";
+                return;
+        }
         my $es = PublicInbox::ExtSearch->new($d);
         for my $k (qw(indexlevel indexsequentialshard)) {
                 my $v = _one_val($self, $pfx, $k) // next;