about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-02-27 02:14:21 +0000
committerEric Wong <e@80x24.org>2016-02-27 10:33:29 +0000
commit2cc034627726da5c73c88d5ff7a8b136cc9ce759 (patch)
tree699218a08f5e9996e90f364d58b98abbbcde89de /lib
parentac6f7081a484a053ddb60a2f8b6b6487664827ac (diff)
downloadpublic-inbox-2cc034627726da5c73c88d5ff7a8b136cc9ce759.tar.gz
No point in comparing an empty string; length() is only
potentially expensive on big strings.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/HTTP.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index f65dedaa..f1016d2f 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -40,7 +40,7 @@ sub event_read { # called by Danga::Socket
 
         return event_read_input($self) if defined $self->{env};
 
-        my $off = $self->{rbuf} eq '' ? 0 : length($self->{rbuf});
+        my $off = length($self->{rbuf});
         my $r = sysread($self->{sock}, $self->{rbuf}, 8192, $off);
         if (defined $r) {
                 return $self->close if $r == 0;