From 2cc034627726da5c73c88d5ff7a8b136cc9ce759 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 27 Feb 2016 02:14:21 +0000 Subject: http: simplify offset calculation slightly No point in comparing an empty string; length() is only potentially expensive on big strings. --- lib/PublicInbox/HTTP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index f65dedaa..f1016d2f 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -40,7 +40,7 @@ sub event_read { # called by Danga::Socket return event_read_input($self) if defined $self->{env}; - my $off = $self->{rbuf} eq '' ? 0 : length($self->{rbuf}); + my $off = length($self->{rbuf}); my $r = sysread($self->{sock}, $self->{rbuf}, 8192, $off); if (defined $r) { return $self->close if $r == 0; -- cgit v1.2.3-24-ge0c7