treewide: shorten temporary filename

File::Temp only requires four 'X' characters (unlike mkstemp(3),
which requires six).  So only so only give it 4 to avoid an
80-column violation and maybe save metadata space on FSes.

6 files changed, 11 insertions, 12 deletions

diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 8e26cba4..68f6c792 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -26,7 +26,7 @@ sub _iso8601 ($) { strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($_[0])) }
 # we open this in the parent process before ->wq_io_do handoff
 sub ovv_out_lk_init ($) {
         my ($self) = @_;
-        my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXXXX",
+        my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXX",
                                         TMPDIR => 1, UNLINK => 0);
         $self->{"lk_id.$self.$$"} = $self->{lock_path} = $tmp->filename;
 }
diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index 826c4b30..16a9a476 100644
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -46,7 +46,7 @@ sub new_file {
 sub tmp_clone {
         my ($self, $dir) = @_;
         require File::Temp;
-        my $tmp = "mm_tmp-$$-XXXXXX";
+        my $tmp = "mm_tmp-$$-XXXX";
         my ($fh, $fn) = File::Temp::tempfile($tmp, EXLOCK => 0, DIR => $dir);
         PublicInbox::Spawn::nodatacow_fd(fileno($fh));
         $self->{dbh}->sqlite_backup_to_file($fn);
diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm
index 1d70975e..92106e75 100644
--- a/lib/PublicInbox/SolverGit.pm
+++ b/lib/PublicInbox/SolverGit.pm
@@ -681,7 +681,7 @@ sub solve ($$$$$) {
         $self->{todo} = [ { %$hints, oid_b => $oid_want } ];
         $self->{patches} = []; # [ $di, $di, ... ]
         $self->{found} = {}; # { abbr => [ ::Git, oid, type, size, $di ] }
-        $self->{tmp} = File::Temp->newdir("solver.$oid_want-XXXXXXXX", TMPDIR => 1);
+        $self->{tmp} = File::Temp->newdir("solver.$oid_want-XXXX", TMPDIR => 1);
 
         dbg($self, "solving $oid_want ...");
         if (my $async = $env->{'pi-httpd.async'}) {
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index d36a63aa..d6e090dd 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -40,7 +40,7 @@ sub tmpdir (;$) {
         unless (defined $base) {
                 ($base) = ($0 =~ m!\b([^/]+)\.[^\.]+\z!);
         }
-        my $tmpdir = File::Temp->newdir("pi-$base-$$-XXXXXX", TMPDIR => 1);
+        my $tmpdir = File::Temp->newdir("pi-$base-$$-XXXX", TMPDIR => 1);
         ($tmpdir->dirname, $tmpdir);
 }
 
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 4130a472..0461257f 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -660,7 +660,7 @@ sub done {
 
 sub write_alternates ($$$) {
         my ($info_dir, $mode, $out) = @_;
-        my $fh = File::Temp->new(TEMPLATE => 'alt-XXXXXXXX', DIR => $info_dir);
+        my $fh = File::Temp->new(TEMPLATE => 'alt-XXXX', DIR => $info_dir);
         my $tmp = $fh->filename;
         print $fh @$out or die "print $tmp: $!\n";
         chmod($mode, $fh) or die "fchmod $tmp: $!\n";
@@ -772,11 +772,11 @@ sub import_init {
 sub diff ($$$) {
         my ($mid, $cur, $new) = @_;
 
-        my $ah = File::Temp->new(TEMPLATE => 'email-cur-XXXXXXXX', TMPDIR => 1);
+        my $ah = File::Temp->new(TEMPLATE => 'email-cur-XXXX', TMPDIR => 1);
         print $ah $cur->as_string or die "print: $!";
         $ah->flush or die "flush: $!";
         PublicInbox::Import::drop_unwanted_headers($new);
-        my $bh = File::Temp->new(TEMPLATE => 'email-new-XXXXXXXX', TMPDIR => 1);
+        my $bh = File::Temp->new(TEMPLATE => 'email-new-XXXX', TMPDIR => 1);
         print $bh $new->as_string or die "print: $!";
         $bh->flush or die "flush: $!";
         my $cmd = [ qw(diff -u), $ah->filename, $bh->filename ];
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index e2d67f6a..9791f02c 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -192,7 +192,7 @@ sub prepare_run {
                 my $dir = dirname($old);
                 same_fs_or_die($dir, $old);
                 my $v = PublicInbox::Search::SCHEMA_VERSION();
-                my $wip = File::Temp->newdir("xapian$v-XXXXXXXX", DIR => $dir);
+                my $wip = File::Temp->newdir("xapian$v-XXXX", DIR => $dir);
                 $tmp->{$old} = $wip;
                 nodatacow_dir($wip->dirname);
                 push @queue, [ $old, $wip ];
@@ -220,8 +220,7 @@ sub prepare_run {
                         $src = [ map { "$old/$_" } @old_shards ];
                 }
                 foreach my $dn (0..$max_shard) {
-                        my $tmpl = "$dn-XXXXXXXX";
-                        my $wip = File::Temp->newdir($tmpl, DIR => $old);
+                        my $wip = File::Temp->newdir("$dn-XXXX", DIR => $old);
                         same_fs_or_die($old, $wip->dirname);
                         my $cur = "$old/$dn";
                         push @queue, [ $src // $cur , $wip ];
@@ -291,7 +290,7 @@ sub cpdb_retryable ($$) {
 }
 
 sub progress_pfx ($) {
-        my ($wip) = @_; # tempdir v2: ([0-9])+-XXXXXXXX
+        my ($wip) = @_; # tempdir v2: ([0-9])+-XXXX
         my @p = split('/', $wip);
 
         # return "xap15/0" for v2, or "xapian15" for v1:
@@ -418,7 +417,7 @@ sub cpdb ($$) { # cb_spawn callback
         if ($opt->{compact}) {
                 my $dir = dirname($new);
                 same_fs_or_die($dir, $new);
-                $ft = File::Temp->newdir("$new.compact-XXXXXX", DIR => $dir);
+                $ft = File::Temp->newdir("$new.compact-XXXX", DIR => $dir);
                 setup_signals();
                 $tmp = $ft->dirname;
                 nodatacow_dir($tmp);