about summary refs log tree commit homepage
path: root/lib/PublicInbox/Xapcmd.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-03-28 09:01:24 +0000
committerEric Wong <e@80x24.org>2021-03-28 23:01:37 +0000
commit80f4192574065106ae72a7a73ee0f02ebd86708a (patch)
treeaf6889740669aa8e05bdef4ddf932f562b3a444b /lib/PublicInbox/Xapcmd.pm
parent8c8bd22ec8c74a3bf66a611a2a0c2d4d76a42ddb (diff)
downloadpublic-inbox-80f4192574065106ae72a7a73ee0f02ebd86708a.tar.gz
File::Temp only requires four 'X' characters (unlike mkstemp(3),
which requires six).  So only so only give it 4 to avoid an
80-column violation and maybe save metadata space on FSes.
Diffstat (limited to 'lib/PublicInbox/Xapcmd.pm')
-rw-r--r--lib/PublicInbox/Xapcmd.pm9
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index e2d67f6a..9791f02c 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -192,7 +192,7 @@ sub prepare_run {
                 my $dir = dirname($old);
                 same_fs_or_die($dir, $old);
                 my $v = PublicInbox::Search::SCHEMA_VERSION();
-                my $wip = File::Temp->newdir("xapian$v-XXXXXXXX", DIR => $dir);
+                my $wip = File::Temp->newdir("xapian$v-XXXX", DIR => $dir);
                 $tmp->{$old} = $wip;
                 nodatacow_dir($wip->dirname);
                 push @queue, [ $old, $wip ];
@@ -220,8 +220,7 @@ sub prepare_run {
                         $src = [ map { "$old/$_" } @old_shards ];
                 }
                 foreach my $dn (0..$max_shard) {
-                        my $tmpl = "$dn-XXXXXXXX";
-                        my $wip = File::Temp->newdir($tmpl, DIR => $old);
+                        my $wip = File::Temp->newdir("$dn-XXXX", DIR => $old);
                         same_fs_or_die($old, $wip->dirname);
                         my $cur = "$old/$dn";
                         push @queue, [ $src // $cur , $wip ];
@@ -291,7 +290,7 @@ sub cpdb_retryable ($$) {
 }
 
 sub progress_pfx ($) {
-        my ($wip) = @_; # tempdir v2: ([0-9])+-XXXXXXXX
+        my ($wip) = @_; # tempdir v2: ([0-9])+-XXXX
         my @p = split('/', $wip);
 
         # return "xap15/0" for v2, or "xapian15" for v1:
@@ -418,7 +417,7 @@ sub cpdb ($$) { # cb_spawn callback
         if ($opt->{compact}) {
                 my $dir = dirname($new);
                 same_fs_or_die($dir, $new);
-                $ft = File::Temp->newdir("$new.compact-XXXXXX", DIR => $dir);
+                $ft = File::Temp->newdir("$new.compact-XXXX", DIR => $dir);
                 setup_signals();
                 $tmp = $ft->dirname;
                 nodatacow_dir($tmp);