diff options
author | Eric Wong <e@80x24.org> | 2021-04-28 07:51:57 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2021-04-28 19:30:54 +0000 |
commit | c572038d133b1b236ae2b6ed67bd973c3f7a5103 (patch) | |
tree | bd371cbd76aadb66b27a6d81e0cc03fc7325173c /lib/PublicInbox/ViewDiff.pm | |
parent | 5e788baf14bd99cc7e428432479eae374343525a (diff) | |
download | public-inbox-c572038d133b1b236ae2b6ed67bd973c3f7a5103.tar.gz |
Prefer "use v5.10", s/base/parent/, rely on "perl -w" for warnings. We also pass a regexp to the split perlop rather than literal SV, since split() will compile a new RE every time.
Diffstat (limited to 'lib/PublicInbox/ViewDiff.pm')
-rw-r--r-- | lib/PublicInbox/ViewDiff.pm | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index e9a7bf69..d2c5fabe 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -7,10 +7,9 @@ # (or reconstruct) blobs. package PublicInbox::ViewDiff; -use 5.010_001; use strict; -use warnings; -use base qw(Exporter); +use v5.10.1; +use parent qw(Exporter); our @EXPORT_OK = qw(flush_diff); use URI::Escape qw(uri_escape_utf8); use PublicInbox::Hval qw(ascii_html to_attr); @@ -122,8 +121,8 @@ sub diff_header ($$$) { my $dctx = { spfx => $spfx }; # get rid of leading "a/" or "b/" (or whatever --{src,dst}-prefix are) - $pa = (split('/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; - $pb = (split('/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; + $pa = (split(m'/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; + $pb = (split(m'/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; if ($pa eq $pb && $pb ne '/dev/null') { $dctx->{Q} = "?b=".uri_escape_utf8($pb, UNSAFE); } else { |