From c572038d133b1b236ae2b6ed67bd973c3f7a5103 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 28 Apr 2021 07:51:57 +0000 Subject: view_diff: minor coding style fixes Prefer "use v5.10", s/base/parent/, rely on "perl -w" for warnings. We also pass a regexp to the split perlop rather than literal SV, since split() will compile a new RE every time. --- lib/PublicInbox/ViewDiff.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'lib/PublicInbox/ViewDiff.pm') diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index e9a7bf69..d2c5fabe 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -7,10 +7,9 @@ # (or reconstruct) blobs. package PublicInbox::ViewDiff; -use 5.010_001; use strict; -use warnings; -use base qw(Exporter); +use v5.10.1; +use parent qw(Exporter); our @EXPORT_OK = qw(flush_diff); use URI::Escape qw(uri_escape_utf8); use PublicInbox::Hval qw(ascii_html to_attr); @@ -122,8 +121,8 @@ sub diff_header ($$$) { my $dctx = { spfx => $spfx }; # get rid of leading "a/" or "b/" (or whatever --{src,dst}-prefix are) - $pa = (split('/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; - $pb = (split('/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; + $pa = (split(m'/', git_unquote($pa), 2))[1] if $pa ne '/dev/null'; + $pb = (split(m'/', git_unquote($pb), 2))[1] if $pb ne '/dev/null'; if ($pa eq $pb && $pb ne '/dev/null') { $dctx->{Q} = "?b=".uri_escape_utf8($pb, UNSAFE); } else { -- cgit v1.2.3-24-ge0c7