about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchView.pm
diff options
authorEric Wong <e@yhbt.net>2020-01-05 23:23:35 +0000
committerEric Wong <e@yhbt.net>2020-01-06 10:21:00 +0000
commit55b707d788ce13696e4411389583e720ea6dab01 (patch)
tree19fcea9f3da92c0183fdb5845c79aaefbe1d53c4 /lib/PublicInbox/SearchView.pm
parent42f390c5e4d8e6619d234a43aa5397c9977cf070 (diff)
There's a bunch of leftover "require" and "use" statements we no
longer need and can get rid of, along with some excessive
imports via "use".

IO::Handle usage isn't always obvious, so add comments
describing why a package loads it.  Along the same lines,
document the tmpdir support as the reason we depend on
File::Temp 0.19, even though every Perl 5.10.1+ user has it.

While we're at it, favor "use" over "require", since it it gives
us extra compile-time checking.
Diffstat (limited to 'lib/PublicInbox/SearchView.pm')
1 files changed, 1 insertions, 5 deletions
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 6587d37f..0d2e71fd 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -10,10 +10,7 @@ use PublicInbox::SearchMsg;
 use PublicInbox::Hval qw/ascii_html obfuscate_addrs/;
 use PublicInbox::View;
 use PublicInbox::WwwAtomStream;
-use PublicInbox::MID qw(MID_ESC);
-use PublicInbox::MIME;
-require PublicInbox::Git;
-require PublicInbox::SearchThread;
+use PublicInbox::SearchThread;
 our $LIM = 200;
 my %rmap_inc;
@@ -350,7 +347,6 @@ package PublicInbox::SearchQuery;
 use strict;
 use warnings;
 use URI::Escape qw(uri_escape);
-use PublicInbox::Hval;
 use PublicInbox::MID qw(MID_ESC);
 sub new {