From 55b707d788ce13696e4411389583e720ea6dab01 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 5 Jan 2020 23:23:35 +0000 Subject: treewide: "require" + "use" cleanup and docs There's a bunch of leftover "require" and "use" statements we no longer need and can get rid of, along with some excessive imports via "use". IO::Handle usage isn't always obvious, so add comments describing why a package loads it. Along the same lines, document the tmpdir support as the reason we depend on File::Temp 0.19, even though every Perl 5.10.1+ user has it. While we're at it, favor "use" over "require", since it it gives us extra compile-time checking. --- lib/PublicInbox/SearchView.pm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'lib/PublicInbox/SearchView.pm') diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index 6587d37f..0d2e71fd 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -10,10 +10,7 @@ use PublicInbox::SearchMsg; use PublicInbox::Hval qw/ascii_html obfuscate_addrs/; use PublicInbox::View; use PublicInbox::WwwAtomStream; -use PublicInbox::MID qw(MID_ESC); -use PublicInbox::MIME; -require PublicInbox::Git; -require PublicInbox::SearchThread; +use PublicInbox::SearchThread; our $LIM = 200; my %rmap_inc; @@ -350,7 +347,6 @@ package PublicInbox::SearchQuery; use strict; use warnings; use URI::Escape qw(uri_escape); -use PublicInbox::Hval; use PublicInbox::MID qw(MID_ESC); sub new { -- cgit v1.2.3-24-ge0c7