about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTP.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-06-10 03:02:11 +0000
committerEric Wong <e@80x24.org>2019-06-10 05:05:15 +0000
commit6feb58ba2e9dee57b474e82e871a8945b537325e (patch)
treef80fe9b7950ecbbd94b83bf13aeb59f39a2a2932 /lib/PublicInbox/NNTP.pm
parenta68d7b5b57fd045e17188ab743905564afbd9b05 (diff)
downloadpublic-inbox-6feb58ba2e9dee57b474e82e871a8945b537325e.tar.gz
In my experience, both are worthless as any normal read/write
call path will be wanting to check errors and deal with them
appropriately; so we can just call event_read, for now.

Eventually, there'll probably be only one callback for dealing
with all in/out/err/hup events to simplify logic, especially w.r.t
TLS socket negotiation.
Diffstat (limited to 'lib/PublicInbox/NNTP.pm')
-rw-r--r--lib/PublicInbox/NNTP.pm5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 5e66d077..85778c44 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -937,11 +937,6 @@ sub do_more ($$) {
         do_write($self, $data);
 }
 
-# callbacks for PublicInbox::DS
-
-sub event_hup { $_[0]->close }
-sub event_err { $_[0]->close }
-
 sub event_write {
         my ($self) = @_;
         update_idle_time($self);