From 6feb58ba2e9dee57b474e82e871a8945b537325e Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 10 Jun 2019 03:02:11 +0000 Subject: ds: do not distinguish between POLLHUP and POLLERR In my experience, both are worthless as any normal read/write call path will be wanting to check errors and deal with them appropriately; so we can just call event_read, for now. Eventually, there'll probably be only one callback for dealing with all in/out/err/hup events to simplify logic, especially w.r.t TLS socket negotiation. --- lib/PublicInbox/NNTP.pm | 5 ----- 1 file changed, 5 deletions(-) (limited to 'lib/PublicInbox/NNTP.pm') diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 5e66d077..85778c44 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -937,11 +937,6 @@ sub do_more ($$) { do_write($self, $data); } -# callbacks for PublicInbox::DS - -sub event_hup { $_[0]->close } -sub event_err { $_[0]->close } - sub event_write { my ($self) = @_; update_idle_time($self); -- cgit v1.2.3-24-ge0c7