about summary refs log tree commit homepage
path: root/lib/PublicInbox/Git.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-09 07:09:30 -0100
committerEric Wong <e@80x24.org>2021-02-10 06:59:03 +0000
commitc57dc1468102aab386ed5dd3ae03d37f5b793aaa (patch)
tree3483c4127a34b498c003629f659d8ecb6a37ccfd /lib/PublicInbox/Git.pm
parenta4dd78f9ff4613f41ae19e0f03584b5f561c0ac1 (diff)
downloadpublic-inbox-c57dc1468102aab386ed5dd3ae03d37f5b793aaa.tar.gz
git: ->qx: respect caller's $/ in array context
This could lead to bad results when doing ls-tree -z
for v2 import in case there's multiple files.  In any case,
the `local $/ = "\0"' in Import.pm is also eliminated to
reduce potential confusion and surprises.
Diffstat (limited to 'lib/PublicInbox/Git.pm')
-rw-r--r--lib/PublicInbox/Git.pm1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index ac7ff267..e176921c 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -364,7 +364,6 @@ sub popen {
 sub qx {
         my $fh = popen(@_);
         if (wantarray) {
-                local $/ = "\n";
                 my @ret = <$fh>;
                 close $fh; # caller should check $?
                 @ret;