diff options
author | Eric Wong <e@80x24.org> | 2023-11-02 09:35:30 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2023-11-03 06:39:28 +0000 |
commit | d3c55d072839286efb2865fe20f2324a9e595e95 (patch) | |
tree | c3a7b450e22a0e9d7e849d53884f6af8af19cee5 /lib/PublicInbox/Config.pm | |
parent | 19f9089343c9e579253db756f2131ee493718ead (diff) | |
download | public-inbox-d3c55d072839286efb2865fe20f2324a9e595e95.tar.gz |
treewide: use ->close to call ProcessIO->CLOSE
This will open the door for us to drop `tie' usage from ProcessIO completely in favor of OO method dispatch. While OO method dispatches (e.g. `$fh->close') are slower than normal subroutine calls, it hardly matters in this case since process teardown is a fairly rare operation and we continue to use `close($fh)' for Maildir writes.
Diffstat (limited to 'lib/PublicInbox/Config.pm')
-rw-r--r-- | lib/PublicInbox/Config.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index 0a572103..01cb536d 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -192,7 +192,7 @@ sub git_config_dump { push(@cmd, '-f', $file) if !@opt_c && defined($file); my $fh = popen_rd(\@cmd, \%env, $opt); my $rv = config_fh_parse($fh, "\0", "\n"); - close $fh or die "@cmd failed: \$?=$?\n"; + $fh->close or die "@cmd failed: \$?=$?\n"; $rv->{-opt_c} = \@opt_c if @opt_c; # for ->urlmatch $rv->{-f} = $file; bless $rv, $class; |